<p><a class="user-mention" data-hovercard-user-id="793526" href="https://github.com/b4n">@b4n</a> I would think you could just write "Closes #XXX" in the final commit message, is that what you're looking for?</p>
<p>I'll amend according to your comments and give you a chance to review again. But in case you don't get another chance for 1.34 I'd go ahead and merge prior to the freeze since you indicated that the rest looks good to you. Is that approach OK for you?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1748#issuecomment-378363498">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ8-xig3KAubhFIatd1814tML5eHTks5tk8ligaJpZM4RqazS">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABDrJ22CSoHEmnXxo2nd8ffYmFXbuZGNks5tk8ligaJpZM4RqazS.gif" height="1" width="1" alt="" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1748#issuecomment-378363498"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@kugel- in #1748: @b4n I would think you could just write \"Closes #XXX\" in the final commit message, is that what you're looking for?\r\n\r\nI'll amend according to your comments and give you a chance to review again. But in case you don't get another chance for 1.34 I'd go ahead and merge prior to the freeze since you indicated that the rest looks good to you. Is that approach OK for you?"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1748#issuecomment-378363498"}}}</script>