<p>I don't think copying the spawn module is a good idea, it was actually moved from the plugin because subprocess communication is a tricky (esp. when you want it to be portable, but even otherwise there's a gazillion ways to shoot yourself in the food without even realizing it) and important piece of code.<br>
I just merged it as it's early in the release cycle and we'll get some testing (hopefully <g-emoji class="g-emoji" alias="crossed_fingers" fallback-src="https://assets-cdn.github.com/images/icons/emoji/unicode/1f91e.png">🤞</g-emoji>).</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1461#issuecomment-371987731">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ7dQWT6mhFD0XUPlvruWRkUplR1Fks5tcyXAgaJpZM4M3KqU">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ7FpI5hf2qpYPqa-xi97UfE2lhOtks5tcyXAgaJpZM4M3KqU.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1461#issuecomment-371987731"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@b4n in #1461: I don't think copying the spawn module is a good idea, it was actually moved from the plugin because subprocess communication is a tricky (esp. when you want it to be portable, but even otherwise there's a gazillion ways to shoot yourself in the food without even realizing it) and important piece of code.\r\nI just merged it as it's early in the release cycle and we'll get some testing (hopefully :crossed_fingers:)."}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1461#issuecomment-371987731"}}}</script>