<blockquote>
<p>One problem here, this tests on the build machine, not the machine the plugin is installed on when its distributed.</p>
</blockquote>
<p>Follow up.</p>
<p>According to our Debian packager the plugin package is tied to a Glib version anyway, so its not going to cause problems for normal users who get it from the repositories.</p>
<p>And if a user is smart enough to build the plugins themselves they are smart enough to handle their Glib version.</p>
<p>So never mind a runtime check.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany-plugins/pull/718#issuecomment-370319606">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ36gEIs39rmgjiVd_PJ-vpRCSRXvks5tbNbhgaJpZM4SbaXs">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ8Tx2rKO2_vpyIas4DItohdBJKPtks5tbNbhgaJpZM4SbaXs.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany-plugins/pull/718#issuecomment-370319606"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany-plugins","title":"geany/geany-plugins","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany-plugins"}},"updates":{"snippets":[{"icon":"PERSON","message":"@elextr in #718: \u003e One problem here, this tests on the build machine, not the machine the plugin is installed on when its distributed.\r\n\r\nFollow up.\r\n\r\nAccording to our Debian packager the plugin package is tied to a Glib version anyway, so its not going to cause problems for normal users who get it from the repositories.\r\n\r\nAnd if a user is smart enough to build the plugins themselves they are smart enough to handle their Glib version.\r\n\r\nSo never mind a runtime check."}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany-plugins/pull/718#issuecomment-370319606"}}}</script>