<p><a href="https://github.com/larsgit223" class="user-mention">@LarsGit223</a> oops I thought you had taken over this one, sorry and apologies to <a href="https://github.com/techee" class="user-mention">@techee</a> :-D</p>
<p>My reasoning for why plugins should use the settings from Geany (assuming they have the same basic form) is that the Geany settings exist even if the plugin is not loaded, and they don't go away if a plugin adds another version of the same setting.  So now there are two places for the same setting.  And one is used in some places and the other setting is used in other places.  That leads to the sort of confusion the OP reported.</p>
<p>Obviously if the settings do something different and there is a good reason to have both then fine, just clearly document which functions use which setting, and possibly why, so users understand the thinking behind the decision.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany-plugins/issues/691#issuecomment-364748179">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ4ULXpsj7vDNmHg-sKGuTp-opbOHks5tTt28gaJpZM4SBFrG">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJyHq7-1eJ10Acfu3kEWLfwh3Gf7lks5tTt28gaJpZM4SBFrG.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany-plugins/issues/691#issuecomment-364748179"></link>
  <meta itemprop="name" content="View Issue"></meta>
</div>
<meta itemprop="description" content="View this Issue on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany-plugins","title":"geany/geany-plugins","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany-plugins"}},"updates":{"snippets":[{"icon":"PERSON","message":"@elextr in #691: @LarsGit223 oops I thought you had taken over this one, sorry and apologies to @techee :-D\r\n\r\nMy reasoning for why plugins should use the settings from Geany (assuming they have the same basic form) is that the Geany settings exist even if the plugin is not loaded, and they don't go away if a plugin adds another version of the same setting.  So now there are two places for the same setting.  And one is used in some places and the other setting is used in other places.  That leads to the sort of confusion the OP reported.\r\n\r\nObviously if the settings do something different and there is a good reason to have both then fine, just clearly document which functions use which setting, and possibly why, so users understand the thinking behind the decision."}],"action":{"name":"View Issue","url":"https://github.com/geany/geany-plugins/issues/691#issuecomment-364748179"}}}</script>