<p>If we want to add some platform-specific code, we could also add it to the gtk-mac-integration library. Under normal conditions such a fix could be applied upstream but with the gtk-osx maintainer's attitude:</p>
<p><a href="https://bugzilla.gnome.org/show_bug.cgi?id=793015" rel="nofollow">https://bugzilla.gnome.org/show_bug.cgi?id=793015</a></p>
<p>I'm not going to do that and we'd have to use a patched version of gtk-mac-integration. We already have to patch it anyway by</p>
<p><a href="https://github.com/geany/geany-osx/blob/master/patches/01-gtk_mac_integration_radio_fix.patch">https://github.com/geany/geany-osx/blob/master/patches/01-gtk_mac_integration_radio_fix.patch</a></p>
<p>because the gtk-osx project maintainer refuses to accept there's a problem in the library and rejects submitted patches:</p>
<p><a href="https://bugzilla.gnome.org/show_bug.cgi?id=744596" rel="nofollow">https://bugzilla.gnome.org/show_bug.cgi?id=744596</a></p>
<p>(When I reported the problem, he closed the bug report saying the problem doesn't exist. When I re-opened the bug and added more details, he closed it again saying we're doing it wrong. Then I re-opened it again because what we are doing is completely legal code after which he rejected the patches. The guy is a joy to work with.)</p>
<p>So since we are patching the library anyway, we can add more patches there and do a similar thing like Chromium. Still it would be good to know first how to reproduce the problem and see if such a patch helps.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/issues/1729#issuecomment-362278867">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJzW099-J2v8hvII_mMuItjf2puQeks5tQce1gaJpZM4RL5Tm">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ2Fm1D8yyZtH22eXc24t9x1_FPk4ks5tQce1gaJpZM4RL5Tm.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/issues/1729#issuecomment-362278867"></link>
  <meta itemprop="name" content="View Issue"></meta>
</div>
<meta itemprop="description" content="View this Issue on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@techee in #1729: If we want to add some platform-specific code, we could also add it to the gtk-mac-integration library. Under normal conditions such a fix could be applied upstream but with the gtk-osx maintainer's attitude:\r\n\r\nhttps://bugzilla.gnome.org/show_bug.cgi?id=793015\r\n\r\nI'm not going to do that and we'd have to use a patched version of gtk-mac-integration. We already have to patch it anyway by\r\n\r\nhttps://github.com/geany/geany-osx/blob/master/patches/01-gtk_mac_integration_radio_fix.patch\r\n\r\nbecause the gtk-osx project maintainer refuses to accept there's a problem in the library and rejects submitted patches:\r\n\r\nhttps://bugzilla.gnome.org/show_bug.cgi?id=744596\r\n\r\n(When I reported the problem, he closed the bug report saying the problem doesn't exist. When I re-opened the bug and added more details, he closed it again saying we're doing it wrong. Then I re-opened it again because what we are doing is completely legal code after which he rejected the patches. The guy is a joy to work with.)\r\n\r\nSo since we are patching the library anyway, we can add more patches there and do a similar thing like Chromium. Still it would be good to know first how to reproduce the problem and see if such a patch helps."}],"action":{"name":"View Issue","url":"https://github.com/geany/geany/issues/1729#issuecomment-362278867"}}}</script>