> Why not saving empty elements? It would make a lot of sense for<br>
> replacement strings: it's totally reasonable to replace with an empty<br>
> string to remove the searched pattern.<br>
<br>
Well OK as the empty string would be the default anyway it might not be<br>
useful in practice, so maybe ignore that part.  Though, I'm still<br>
curious why you went to the trouble not to save those?<br>


<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1745#issuecomment-360367183">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJz1Mv3uRvDCy7kwH2C1JhFKB2RaCks5tOBSygaJpZM4Rk8q8">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ2VGNUmLslr86UDDBOdqU23YqHwPks5tOBSygaJpZM4Rk8q8.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1745#issuecomment-360367183"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@b4n in #1745: \u003e Why not saving empty elements? It would make a lot of sense for\n\u003e replacement strings: it's totally reasonable to replace with an empty\n\u003e string to remove the searched pattern.\n\nWell OK as the empty string would be the default anyway it might not be\nuseful in practice, so maybe ignore that part.  Though, I'm still\ncurious why you went to the trouble not to save those?\n"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1745#issuecomment-360367183"}}}</script>