<p><b>@b4n</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/1745#discussion_r163659861">src/search.c</a>:</p>
<pre style='color:#555'>> @@ -2297,3 +2337,59 @@ void search_find_again(gboolean change_direction)
                                toolbar_get_widget_child_by_name("SearchEntry"), (result > -1));
        }
 }
+
+
+static void load_combo_box_history(GtkWidget *combo_entry, gchar **recent_terms)
+{
+       guint i, len = 0;
+
+       if (recent_terms != NULL)
+       {
+               len = g_strv_length(recent_terms);
</pre>
<p>Implementation note: <code>g_strv_lenght()</code> is fairly costly (not that it actually really matters here, but well), and not really necessary here.  You could simply do:</p>
<div class="highlight highlight-source-c"><pre><span class="pl-k">for</span> (; recent_terms != <span class="pl-c1">NULL</span> && *recent_terms != <span class="pl-c1">NULL</span>; recent_terms++)
{
        <span class="pl-c1">ui_combo_box_add_to_history</span>(<span class="pl-c1">GTK_COMBO_BOX_TEXT</span>(combo_entry), *recent_terms, <span class="pl-c1">0</span>);
}</pre></div>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1745#pullrequestreview-91309141">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJxQSgUOZyTNCOja6SthFa8W0VyuGks5tN4pZgaJpZM4Rk8q8">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ-nfgosO7aMx_wKN_HvCOZCiT_L7ks5tN4pZgaJpZM4Rk8q8.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1745#pullrequestreview-91309141"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@b4n commented on #1745"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1745#pullrequestreview-91309141"}}}</script>