<p><b>@kugel-</b> requested changes on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/1703#discussion_r162862103">src/gtkcompat.h</a>:</p>
<pre style='color:#555'>> @@ -98,6 +98,26 @@ G_BEGIN_DECLS
 #endif
 
 
+#if !GTK_CHECK_VERSION(3, 4, 0)
+static inline guint gtkcompat_builder_add_from_resource(GtkBuilder *builder,
+       const gchar *resource_path, GError **error)
+{
+       GBytes *bytes = g_resources_lookup_data(resource_path,
+               G_RESOURCE_LOOKUP_FLAGS_NONE, error);
+       if (bytes == NULL)
</pre>
<p>This is worth a a g_error(), as it means Geany wasn't compiled correctly.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/1703#discussion_r163407068">src/Makefile.am</a>:</p>
<pre style='color:#555'>> +            --target=$@ \
+               --sourcedir=$(srcdir) \
+               --generate-source \
+               --c-name="geany" \
+               --manual-register \
+               --internal \
+                       $(srcdir)/geany.gresource.xml
+resources.h: $(resource_dependencies)
+       $(AM_V_GEN)$(GLIB_COMPILE_RESOURCES) \
+               --target=$@ \
+               --sourcedir=$(srcdir) \
+               --generate-header \
+               --c-name="geany" \
+               --manual-register \
+               --internal \
+                       $(srcdir)/geany.gresource.xml
</pre>
<p>This runs glib-compile-resources twice. It's usually better to a construct pattern rule, where (GNU) make recognizes that one rule produces multiple output files. That's assuming it's even possible with, I haven't checked.</p>
<pre><code>%.gresource.c %.gresource.h: %.gresource.xml $(top_srcdir)/data/geany.glade
[…]
</code></pre>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1703#pullrequestreview-90385252">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ7gAK0OD9RsguhZ6zLSYiw6sWSfKks5tNmeGgaJpZM4QzP2F">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJzbdSghIrUV8AZfqCDTB9qQpKJB6ks5tNmeGgaJpZM4QzP2F.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1703#pullrequestreview-90385252"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@kugel- requested changes on #1703"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1703#pullrequestreview-90385252"}}}</script>