<p><b>@b4n</b> requested changes on this pull request.</p>

<p>More to come</p><hr>

<p>In <a href="https://github.com/geany/geany-plugins/pull/677#discussion_r162255709">build/webhelper.m4</a>:</p>
<pre style='color:#555'>> @@ -19,8 +19,8 @@ AC_DEFUN([GP_CHECK_WEBHELPER],
         fi
     fi
 
-    GP_CHECK_GTK3([webkit_package=webkitgtk-3.0],
-                  [webkit_package=webkit-1.0])
+    GP_CHECK_GTK3([webkit_package=webkit2gtk-4.0],
+                  [webkit_package=webkit2gtk-4.0])
</pre>
<p>that's wrong, webkit2gtk-4.0 don't work with GTK2</p>

<hr>

<p>In <a href="https://github.com/geany/geany-plugins/pull/677#discussion_r162255824">build/markdown.m4</a>:</p>
<pre style='color:#555'>> @@ -49,8 +49,8 @@ AC_DEFUN([GP_CHECK_MARKDOWN],
     GTK_VERSION=2.16
     WEBKIT_VERSION=1.1.13
 
-    GP_CHECK_GTK3([webkit_package=webkitgtk-3.0],
-                  [webkit_package=webkit-1.0])
+    GP_CHECK_GTK3([webkit_package=webkit2gtk-4.0],
+                  [webkit_package=webkit2gtk-4.0])
</pre>
<p>same that with WebHelper, webkit2gtk-4.0 is wrong for GTK2</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany-plugins/pull/677#pullrequestreview-89679247">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ62FB9Ziw6zvS5LPbOJh_HAvk7HIks5tLvQzgaJpZM4RhwhT">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJxebjWMeaBOk_jaeqwUhQMbgMFo2ks5tLvQzgaJpZM4RhwhT.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany-plugins/pull/677#pullrequestreview-89679247"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany-plugins","title":"geany/geany-plugins","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany-plugins"}},"updates":{"snippets":[{"icon":"PERSON","message":"@b4n requested changes on #677"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany-plugins/pull/677#pullrequestreview-89679247"}}}</script>