<blockquote>
<p>IIRC there have been a few other keypress functions that don't return a proper value in some cases</p>
</blockquote>
<p>It did return a "proper" value (ie. <code>FALSE</code>), just that now we don't want the event to propagate since there's something that will now handle it (redundantly) upstream.</p>
<blockquote>
<p>So there are probably more of these, anybody know an automated checking method?</p>
</blockquote>
<p>Could probably grep for <code>gboolean</code> and <code>GdkEvent</code> on the same line.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1741#issuecomment-357685583">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ-FF7Ahl1WBVsBrZT7lYZ_gwYXiTks5tK1UzgaJpZM4ReBXE">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJzHL2NCg_1vA5aJmS0eUxn2fSUkNks5tK1UzgaJpZM4ReBXE.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1741#issuecomment-357685583"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@codebrainz in #1741: \u003e IIRC there have been a few other keypress functions that don't return a proper value in some cases\r\n\r\nIt did return a \"proper\" value (ie. `FALSE`), just that now we don't want the event to propagate since there's something that will now handle it (redundantly) upstream.\r\n\r\n\u003e So there are probably more of these, anybody know an automated checking method?\r\n\r\nCould probably grep for `gboolean` and `GdkEvent` on the same line."}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1741#issuecomment-357685583"}}}</script>