<p>I have merged this as is because:</p>
<ol>
<li>
<p>It works for me and others</p>
</li>
<li>
<p>The remaining issues appear to only be stylistic in code and manual, they can be fixed later if "somebody" is interested enough</p>
</li>
<li>
<p>those who understand accessibility issues will understand that colour perception issues affect a significant proportion of the population, who have been unable to use dark themes due to hard coded colours whilst we bickered about code style</p>
</li>
</ol>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1382#issuecomment-357350181">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJwq72OfuVBo26N3PxB6gRhFZ51wyks5tJ8WagaJpZM4Lwb0d">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJyaBRziShp5D8HRB7KMXpQROLQi7ks5tJ8WagaJpZM4Lwb0d.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1382#issuecomment-357350181"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@elextr in #1382: I have merged this as is because:\r\n\r\n1. It works for me and others\r\n\r\n2. The remaining issues appear to only be stylistic in code and manual, they can be fixed later if \"somebody\" is interested enough\r\n\r\n3. those who understand accessibility issues will understand that colour perception issues affect a significant proportion of the population, who have been unable to use dark themes due to hard coded colours whilst we bickered about code style"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1382#issuecomment-357350181"}}}</script>