<p>Noticed with GCC 7 using <code>-Wall -Wextra -Wno-unused-parameter</code> warning options.</p>
<p>There's still a warning in <code>scintilla/src/Editor.cxx:205</code> but I left that for upstream to fix.</p>
<p>For some reason the warning mentioned in Issue <a href="https://github.com/geany/geany/issues/1683" class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="272788496" data-permission-text="Issue title is private" data-url="https://github.com/geany/geany/issues/1683">#1683</a> doesn't occur anymore here, so I didn't fix it.</p>
<p>It would be great if someone could double-check the switch case fall-through changes to ensure I didn't actually mask real bugs, and that the bug I fixed in <code>keybindings.c</code> was actually correct.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/geany/geany/pull/1725'>https://github.com/geany/geany/pull/1725</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Fix pointer and character constant comparison</li>
  <li>Fix comparison between signed and unsigned integers</li>
  <li>Fix missing initializer for field warnings</li>
  <li>Fix missing initializer for field warnings in parsers</li>
  <li>Adjust 'fall through' comments to be recognized by GCC</li>
  <li>Add more 'fall through' comments for switch cases</li>
  <li>Remove some unused variables</li>
  <li>Fix comparison between signed and unsigned integers</li>
  <li>Add 'fall through' comments and fix actual bug</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/geany/geany/pull/1725/files#diff-0">ctags/main/parse.c</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/geany/geany/pull/1725/files#diff-1">ctags/main/xtag.c</a>
    (10)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/geany/geany/pull/1725/files#diff-2">ctags/parsers/actionscript.c</a>
    (20)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/geany/geany/pull/1725/files#diff-3">ctags/parsers/cobol.c</a>
    (12)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/geany/geany/pull/1725/files#diff-4">ctags/parsers/fortran.c</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/geany/geany/pull/1725/files#diff-5">ctags/parsers/html.c</a>
    (10)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/geany/geany/pull/1725/files#diff-6">ctags/parsers/perl.c</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/geany/geany/pull/1725/files#diff-7">ctags/parsers/r.c</a>
    (1)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/geany/geany/pull/1725/files#diff-8">src/editor.c</a>
    (7)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/geany/geany/pull/1725/files#diff-9">src/encodings.c</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/geany/geany/pull/1725/files#diff-10">src/highlighting.c</a>
    (3)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/geany/geany/pull/1725/files#diff-11">src/keybindings.c</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/geany/geany/pull/1725/files#diff-12">src/search.c</a>
    (1)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/geany/geany/pull/1725/files#diff-13">src/tools.c</a>
    (1)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/geany/geany/pull/1725.patch'>https://github.com/geany/geany/pull/1725.patch</a></li>
  <li><a href='https://github.com/geany/geany/pull/1725.diff'>https://github.com/geany/geany/pull/1725.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1725">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJy2gLtxgM1sHxwhwbEyUtVdtpJQFks5tCbREgaJpZM4RJPDd">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ6RFBarMWfeEK2PBaZhJZmrn4jMoks5tCbREgaJpZM4RJPDd.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1725"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Fix new GCC warnings (#1725)"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1725"}}}</script>