<p><b>@b4n</b> requested changes on this pull request.</p>

<p>For the WebHelper plugin: I think it's a good idea to get Webkit2 support, but I think this needs more work to be mergeable.</p><hr>

<p>In <a href="https://github.com/geany/geany-plugins/pull/656#discussion_r155914626">webhelper/src/gwh-browser.c</a>:</p>
<pre style='color:#555'>>      GdkPixbuf *icon;
-    
-    icon = gwh_pixbuf_new_from_uri (icon_uri, NULL);
+    GtkImage *image;
+    gtk_image_set_from_surface (image, favicon);
+    icon = gtk_image_get_pixbuf(image);
</pre>
<p>does this work?  I would be highly surprised if it does, GtkImage is not necessarily (well, I think never) using Pixbuf backed data, and so the <code>get_pixbuf()</code> method will probably return <code>NULL</code> here, doesn't it?</p>

<hr>

<p>In <a href="https://github.com/geany/geany-plugins/pull/656#discussion_r155914680">webhelper/src/gwh-browser.c</a>:</p>
<pre style='color:#555'>>          break;
       
       case GDK_SCROLL_UP:
-        webkit_web_view_zoom_in (WEBKIT_WEB_VIEW (self->priv->web_view));
+        webkit_web_view_set_zoom_level (WEBKIT_WEB_VIEW (self->priv->web_view), 1.0);
</pre>
<p>this doesn't really make any sense, resetting the zoom to 1 when it should zoom in/out</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany-plugins/pull/656#pullrequestreview-82318024">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ-aH0zyTG5eC1o-JOm4nvK_jBoqQks5s-iiTgaJpZM4Q74OD">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ55pQhSfdlp4byCx_SACIF6ILX1uks5s-iiTgaJpZM4Q74OD.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany-plugins/pull/656#pullrequestreview-82318024"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany-plugins","title":"geany/geany-plugins","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany-plugins"}},"updates":{"snippets":[{"icon":"PERSON","message":"@b4n requested changes on #656"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany-plugins/pull/656#pullrequestreview-82318024"}}}</script>