<p>From my early tests it works fine loading and saving embedded NUL bytes, but I expect many features not to work properly (although e.g. regex search seems happy, yet displaying results not so much).  It however should help getting to a point where these could be handled properly, and is handy also for slightly broken files and alike.<br>
Anyway for now such files are loaded read-only and display a warning to the user to avoid most problems.</p>
<p>Related to (and should fix for the most part) <a href="https://github.com/geany/geany/issues/618" class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="102208045" data-permission-text="Issue title is private" data-url="https://github.com/geany/geany/issues/618">#618</a> and <a href="https://github.com/geany/geany/issues/1708" class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="279102732" data-permission-text="Issue title is private" data-url="https://github.com/geany/geany/issues/1708">#1708</a> (and possibly others).</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/geany/geany/pull/1709'>https://github.com/geany/geany/pull/1709</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Avoid weird length value</li>
  <li>Add sci_set_text_with_length()</li>
  <li>Don't cut the loaded data at the first NUL when passing it to Scintilla</li>
  <li>Don't cut UTF-8 documents at the first NUL byte when saving them</li>
  <li>encodings: Accept NULs when validating UTF-8</li>
  <li>Properly load files with embedded NULs</li>
  <li>Show an infobar for files with embedded NULs</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/geany/geany/pull/1709/files#diff-0">src/document.c</a>
    (58)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/geany/geany/pull/1709/files#diff-1">src/documentprivate.h</a>
    (1)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/geany/geany/pull/1709/files#diff-2">src/encodings.c</a>
    (118)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/geany/geany/pull/1709/files#diff-3">src/encodingsprivate.h</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/geany/geany/pull/1709/files#diff-4">src/sciwrappers.c</a>
    (10)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/geany/geany/pull/1709/files#diff-5">src/sciwrappers.h</a>
    (2)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/geany/geany/pull/1709.patch'>https://github.com/geany/geany/pull/1709.patch</a></li>
  <li><a href='https://github.com/geany/geany/pull/1709.diff'>https://github.com/geany/geany/pull/1709.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1709">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJw7DgHj1kkGZef9HHjemJVpNx4-dks5s9QXhgaJpZM4Q18TU">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ85lBKiPR1tmCGR4ybwBSB8CcqNCks5s9QXhgaJpZM4Q18TU.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1709"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"WIP: NUL byte support (#1709)"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1709"}}}</script>