<p><b>@b4n</b> commented on this pull request.</p>

<p>Overall, why not.</p><hr>

<p>In <a href="https://github.com/geany/geany/pull/1703#discussion_r154509875">src/ui_utils.c</a>:</p>
<pre style='color:#555'>> @@ -2440,20 +2441,32 @@ void ui_init_builder(void)
        gtk_builder_set_translation_domain(builder, GETTEXT_PACKAGE);
 
        error = NULL;
-       interface_file = g_build_filename(app->datadir, "geany.glade", NULL);
-       if (! gtk_builder_add_from_file(builder, interface_file, &error))
+       ui_data = g_resource_lookup_data(geany_get_resource(),
+               "/org/geany/Geany/geany.glade", G_RESOURCE_LOOKUP_FLAGS_NONE, &error);
+       if (ui_data == NULL)
</pre>
<p>what about combining this with the check below with a <code>||</code>, as the body is almost totally the same (but for the <code>ui_data</code> unrefing part)</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/1703#discussion_r154510133">src/ui_utils.c</a>:</p>
<pre style='color:#555'>> @@ -2440,20 +2441,32 @@ void ui_init_builder(void)
        gtk_builder_set_translation_domain(builder, GETTEXT_PACKAGE);
 
        error = NULL;
-       interface_file = g_build_filename(app->datadir, "geany.glade", NULL);
-       if (! gtk_builder_add_from_file(builder, interface_file, &error))
+       ui_data = g_resource_lookup_data(geany_get_resource(),
+               "/org/geany/Geany/geany.glade", G_RESOURCE_LOOKUP_FLAGS_NONE, &error);
</pre>
<p>Too bad we can't use <a href="https://developer.gnome.org/gtk3/stable/GtkBuilder.html#gtk-builder-add-from-resource" rel="nofollow"><code>gtk_builder_add_from_resource()</code></a>… maybe we should simply add compatibility for it on GTK < 3.4?</p>
<div class="highlight highlight-source-c"><pre>#<span class="pl-k">if</span> !GTK_CHECK_VERSION(3, 4)
guint <span class="pl-en">gtkcompat_builder_add_from_resource</span>(GtkBuilder *builder, <span class="pl-k">const</span> gchar resource_path, GError **error)
{
    guint success = <span class="pl-c1">0</span>;
    GBytes *bytes = <span class="pl-c1">g_resources_lookup_data</span>(resource_path, G_RESOURCE_LOOKUP_FLAGS_NONE, error);
    gsize bytes_size;

    <span class="pl-k">if</span> (bytes)
        success = <span class="pl-c1">gtk_builder_add_from_string</span>(builder, <span class="pl-c1">g_bytes_get_data</span>(bytes, &bytes_size), bytes_size, error);

    <span class="pl-k">return</span> success;
}
#<span class="pl-k">define</span> <span class="pl-en">gtk_builder_add_from_resource</span> gtkcompat_builder_add_from_resource
#<span class="pl-k">endif</span></pre></div>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1703#pullrequestreview-80687721">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ1paca2OQKzKb6yTgg5VyFaxl9f8ks5s8eAwgaJpZM4QzP2F">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJyjbTgK9hd0D3i9SpHWUxevLuxjgks5s8eAwgaJpZM4QzP2F.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1703#pullrequestreview-80687721"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@b4n commented on #1703"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1703#pullrequestreview-80687721"}}}</script>