<blockquote>
<p>Thats why its a stupid warning (or at least stupid to enable by default) because many system interfaces use int as a counter (like argc) and everybody knows they are never negative</p>
</blockquote>
<p>To be fair, it's not the <em>actual</em> <code>argc</code>, it's a random value popped off the Lua stack, it could be anything and the code only guards against value <code>0</code>, not <code>< 0</code>.</p>
<p>Also, unrelated, that line looks wrong because of the order of operations and missing parenthesis, I believe it will allocate room for the needed pointers plus one byte. Presumably it's meant to be <code>sizeof(gchar*) * (argc+1)</code> to allocate storage for the number of pointers plus one extra pointer for the sentinel <code>NULL</code> as is customary with <code>argv</code>/<code>GStrv</code>.</p>
<p>To fix the warning and bug, it could probably be changed to:</p>
<div class="highlight highlight-source-c"><pre>argv = g_malloc0_n(argc+<span class="pl-c1">1</span>, <span class="pl-k">sizeof</span>(gchar*));</pre></div>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany-plugins/issues/646#issuecomment-345984959">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ8JXh2ANYpr-KYxBgWcS-ahx8QqFks5s4qbOgaJpZM4Qi3Uc">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJxFr6wpgXKfnMlR6QoSkVlV6ItgDks5s4qbOgaJpZM4Qi3Uc.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany-plugins/issues/646#issuecomment-345984959"></link>
  <meta itemprop="name" content="View Issue"></meta>
</div>
<meta itemprop="description" content="View this Issue on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany-plugins","title":"geany/geany-plugins","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany-plugins"}},"updates":{"snippets":[{"icon":"PERSON","message":"@codebrainz in #646: \u003e Thats why its a stupid warning (or at least stupid to enable by default) because many system interfaces use int as a counter (like argc) and everybody knows they are never negative\r\n\r\nTo be fair, it's not the _actual_ `argc`, it's a random value popped off the Lua stack, it could be anything and the code only guards against value `0`, not `\u003c 0`.\r\n\r\nAlso, unrelated, that line looks wrong because of the order of operations and missing parenthesis, I believe it will allocate room for the needed pointers plus one byte. Presumably it's meant to be `sizeof(gchar*) * (argc+1)` to allocate storage for the number of pointers plus one extra pointer for the sentinel `NULL` as is customary with `argv`/`GStrv`.\r\n\r\nTo fix the warning and bug, it could probably be changed to:\r\n\r\n```c\r\nargv = g_malloc0_n(argc+1, sizeof(gchar*));\r\n```\r\n"}],"action":{"name":"View Issue","url":"https://github.com/geany/geany-plugins/issues/646#issuecomment-345984959"}}}</script>