<p>Yeah, looks like GCC can't propogate the value limitation from the check to the sprintf, or has a bug that it doesn't notice that cmd is unsigned and can never get a minus sign.</p>
<p>Anyhow easy solution is add a char to the buffer.</p>
<p>As discussed on IRC maybe also look at removing the initialisation, I can't remember why its there now, but seems useless.</p>
<p>I don't have gcc7 to test yet.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/issues/1683#issuecomment-343351334">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ6Qom90RV2WQGMlBZmV3HLjc85Deks5s06zAgaJpZM4QY7sU">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ_CbqzR2BXiHl3x30TkYSgI51_GHks5s06zAgaJpZM4QY7sU.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/issues/1683#issuecomment-343351334"></link>
  <meta itemprop="name" content="View Issue"></meta>
</div>
<meta itemprop="description" content="View this Issue on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@elextr in #1683: Yeah, looks like GCC can't propogate the value limitation from the check to the sprintf, or has a bug that it doesn't notice that cmd is unsigned and can never get a minus sign.\r\n\r\nAnyhow easy solution is add a char to the buffer.\r\n\r\nAs discussed on IRC maybe also look at removing the initialisation, I can't remember why its there now, but seems useless.\r\n\r\nI don't have gcc7 to test yet."}],"action":{"name":"View Issue","url":"https://github.com/geany/geany/issues/1683#issuecomment-343351334"}}}</script>