<p><b>@techee</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/1636#discussion_r144418654">src/keybindings.c</a>:</p>
<pre style='color:#555'>>              mods |= GEANY_PRIMARY_MOD_MASK;
+               mods &= ~GDK_MOD2_MASK;
</pre>
<p>I slightly prefer my version - it's a bit easier to understand (at least by my poor brain) and it's guaranteed to set/clear the bits while the XOR depends on the actual value of mods (but it probably won't contain GEANY_PRIMARY_MOD_MASK bit and is guaranteed to have GDK_MOD2_MASK set).</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1636#discussion_r144418654">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ9F3jOPP6epvv4U6y___agxnSLpBks5srojvgaJpZM4P3W6G">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ1dx488votSRScugCD5VrFar02YXks5srojvgaJpZM4P3W6G.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1636#discussion_r144418654"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@techee commented on #1636"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1636#discussion_r144418654"}}}</script>