<p>I noticed this issue when working on <a href="https://github.com/geany/geany/pull/1633" class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="263755966" data-permission-text="Issue title is private" data-url="https://github.com/geany/geany/issues/1633">#1633</a> and <a href="https://github.com/geany/geany/pull/1395" class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="207836557" data-permission-text="Issue title is private" data-url="https://github.com/geany/geany/issues/1395">#1395</a> and seeing keybindings like <code><Primary>something</code> is rather confusing.</p>
<blockquote>
<p>Note that the user can directly edit the shortcuts in the keybindings prefs dialog, they don't have to use the capture sub-dialog. As there is no way of un-translating key names so they have to be in the portable form, which happens to be English.</p>
</blockquote>
<p>Does anybody really use the possibility to edit the keybindings directly? I don't think anyone wants to write keybindings like <code><Primary><Shift>s</code> by hand. I would personally just remove the possibility of manual editing and then <code>gtk_accelerator_get_label()</code> could be used to show the user-friendly name only. Note the string above the keybindings list is incorrect: "...or double click on an action to edit the string representation of the shortcut directly" isn't true because double-clicking makes the Grab Key dialog appear (one would have to slowly double-click).</p>
<p>If manual editing is a hard-requirement there could be an edit box below the symbol list tree which could get filled with the currently selected keybinding in the form of <code>gtk_accelerator_name()</code> which could be edited there.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/issues/1630#issuecomment-335087507">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ-ctdpiZ15BuHV7xxGWLtQT_BEcwks5sqdGogaJpZM4PxV50">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJyelVdRXi_RKjcP-Io-KnTefezJmks5sqdGogaJpZM4PxV50.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/issues/1630#issuecomment-335087507"></link>
  <meta itemprop="name" content="View Issue"></meta>
</div>
<meta itemprop="description" content="View this Issue on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@techee in #1630: I noticed this issue when working on #1633 and #1395 and seeing keybindings like `\u003cPrimary\u003esomething` is rather confusing.\r\n\r\n\u003e Note that the user can directly edit the shortcuts in the keybindings prefs dialog, they don't have to use the capture sub-dialog. As there is no way of un-translating key names so they have to be in the portable form, which happens to be English.\r\n\r\nDoes anybody really use the possibility to edit the keybindings directly? I don't think anyone wants to write keybindings like `\u003cPrimary\u003e\u003cShift\u003es` by hand. I would personally just remove the possibility of manual editing and then `gtk_accelerator_get_label()` could be used to show the user-friendly name only. Note the string above the keybindings list is incorrect: \"...or double click on an action to edit the string representation of the shortcut directly\" isn't true because double-clicking makes the Grab Key dialog appear (one would have to slowly double-click).\r\n\r\nIf manual editing is a hard-requirement there could be an edit box below the symbol list tree which could get filled with the currently selected keybinding in the form of `gtk_accelerator_name()` which could be edited there."}],"action":{"name":"View Issue","url":"https://github.com/geany/geany/issues/1630#issuecomment-335087507"}}}</script>