<p>At the moment there's a problem with keybinding creation and processing.<br>
When a keybinding is accessed using shift such as the zoom in keybinding<br>
<code>Ctrl-+</code> which on English keyboard requires pressing <code><Ctrl><Shift>=</code>, the<br>
<code><Shift></code> key is preserved right now. This is visible when changing<br>
keybindings - pressing the above key combination leads to<br>
<code><Primary><Shift>+</code>. This is incorrect - the keybinding should either<br>
be <code><Primary><Shift>=</code> or <code><Primary>+</code> but in <code><Primary><Shift>+</code> there's<br>
extra <code><Shift></code> which leads to problems.</p>
<p>On linux the problems aren't so much visible - the problem is visible<br>
when changing keybindings as mentioned above. Even though this<br>
particular keybinding isn't executed through on_key_press_event()<br>
because the combination <code><Primary><Shift>+</code> doesn't correspond to the<br>
default <code><Primary>+</code> value, it's executed by GTK as an accelerator so<br>
the problem isn't directly visible.</p>
<p>This might however break when a user modifies this keybinding to the<br>
wrong value <code><Primary><Shift>+</code> and when the user is using multiple<br>
keyboards such as English where + has to be accessed over shift<br>
and German where typing + doesn't require shift. The keybinding will<br>
stop working on the German keyboard in this case because of the<br>
extra shift.</p>
<p>On MacOS the accelerator isn't executed for some reason and non-<br>
letter keybindings don't work when shift is used.</p>
<p>To fix the issue we can use gdk_keymap_translate_keyboard_state()<br>
which reports "consumed" modifiers - that is those which lead to<br>
typing the secondary character. However, we don't want this to happen<br>
when typing alphabetical characters because it's easier to notice<br>
the use of shift in <code><Ctrl><Shift>r</code> than in <code><Ctrl>R</code>. Modifier<br>
consumption is undone in this case.</p>
<p>Should also fix <a href="https://github.com/geany/geany/issues/694" class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="111119557" data-permission-text="Issue title is private" data-url="https://github.com/geany/geany/issues/694">#694</a></p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/geany/geany/pull/1633'>https://github.com/geany/geany/pull/1633</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Normalise key events when creating/processing keybindings</li>
  <li>Eliminate keybindings_check_event()</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/geany/geany/pull/1633/files#diff-0">src/keybindings.c</a>
    (44)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/geany/geany/pull/1633/files#diff-1">src/keybindings.h</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/geany/geany/pull/1633/files#diff-2">src/prefs.c</a>
    (16)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/geany/geany/pull/1633.patch'>https://github.com/geany/geany/pull/1633.patch</a></li>
  <li><a href='https://github.com/geany/geany/pull/1633.diff'>https://github.com/geany/geany/pull/1633.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1633">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ1Ovf3GOU28w9vfsLERqDbmxP9ypks5sqUc3gaJpZM4Px3vS">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ1o4eV6Op5a4_zg1RnCIzmI61Bwaks5sqUc3gaJpZM4Px3vS.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1633"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Normalise key events when creating/processing keybindings (#1633)"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1633"}}}</script>