<p><b>@techee</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/1395#discussion_r140652208">src/keybindings.c</a>:</p>
<pre style='color:#555'>> @@ -782,6 +768,36 @@ static void load_kb(GeanyKeyGroup *group, GeanyKeyBinding *kb, gpointer user_dat
 }
 
 
+static void init_platform_kb(void)
+{
+#ifdef __APPLE__
+       gchar *configfile = g_build_filename(app->datadir, "keybindings_osx.conf", NULL);
</pre>
<p>Great! I knew you wouldn't resist the temptation to mess with m4 :-)</p>
<p>But the patch doesn't do exactly the right thing. The point of my patch was to keep Geany's keybindings.conf and only override the keybindings which have to change inside keybindings_osx.conf so it doesn't have to change every time some new keybinding is added and it's easier to see only the changes. See the calls of init_default_kb() followed by init_system_kb() which does the overrides.</p>
<p>So what I assumed you had in mind in your original comment was to keep <code>keybindings.conf</code> as it is now but then on install time copy only the keybindings file specific to the used platform and rename it to e.g. <code>keybindings_patform.conf</code> which would be referenced in the sources so there wouldn't have to be any ifdefs and only one version of platform-specific keybindings would be installed.</p>
<p>Also I think it would be best to keep the platform-specific keybinding files inside the data dir in sources and not to move it under osx as they will usually have to be updated together.</p>
<p>Now the question is how hard this would be to do this and whether it's worth the work...</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1395#discussion_r140652208">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ5YheAf7wHSpVrvFJ-AXjzeoT5PPks5slijXgaJpZM4MB2vq">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ5lzFuTkj331dmUkg71i458KmKvZks5slijXgaJpZM4MB2vq.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1395#discussion_r140652208"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@techee commented on #1395"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1395#discussion_r140652208"}}}</script>