<p><b>@b4n</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/1598#discussion_r140639530">src/symbols.c</a>:</p>
<pre style='color:#555'>>      GTree *tree;
-       if (g_hash_table_lookup_extended(table, tag->name, NULL, (gpointer *) &tree) &&
-               ! utils_str_equal(parent_name, tag->name) /* prevent Foo::Foo from making parent = child */)
+
+       if (EMPTY(tag->scope))
+       {
+               /* simple case, just use the tag name */
+               name = tag->name;
</pre>
<p>That was a vain attempt at over-optimization to avoid memory allocation in the simple case.  And it'd need profiling, but it might be worth it as it's likely to be the most common case (root scope symbol and no duplicate).  But if it just adds complexity for the reader I'll drop it.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1598#discussion_r140639530">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ9_ZLjSDM2eUdJ3zlr7vbzwO3YYDks5slVQ9gaJpZM4PKvxv">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ3dWW2lv2rx0_I4XYDT1eVyaKr1fks5slVQ9gaJpZM4PKvxv.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1598#discussion_r140639530"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@b4n commented on #1598"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1598#discussion_r140639530"}}}</script>