<p>Fix the symbols tree hierarchy by considering the whole scope when adding a tag, avoiding choosing the wrong parent when several tags have the same name.  Until now, to avoid such misbehavior we only used to choose the parent candidate that appeared last (line-wise) before the child.  It works in most typical situations as generally tag names are fairly unique, and children appear right after their parent.</p>
<p>However, there are cases that are trickier and cannot be handled that way.  In the following valid C++ snippet, it is impossible to know whether <code>function</code> should be listed under the namespace <code>A</code> or the<br>
class <code>A</code> without looking at its full scope:</p>
<div class="highlight highlight-source-c++"><pre><span class="pl-k">namespace</span> <span class="pl-en">A</span> {
    <span class="pl-k">namespace</span> <span class="pl-en">B</span> {
        <span class="pl-k">class</span> <span class="pl-en">A</span> {
            <span class="pl-k">void</span> <span class="pl-en">method</span>() {}
        };
    };
    <span class="pl-k">void</span> <span class="pl-en">function</span>() {}
};</pre></div>
<p>And it is a real-world problem for some parsers like the JSON parser that generates numeric indices for array elements name, often leading to several possibly close duplicates.</p>
<p>Additionally, to prevent trying to set a tag as its own parent, the code guarded against accepting a parent if the child had the same name, lading to incorrect hierarchy for <code>method</code> in cases like this:</p>
<div class="highlight highlight-source-c++"><pre><span class="pl-k">namespace</span> <span class="pl-en">A</span> {
    <span class="pl-k">class</span> <span class="pl-en">A</span> {
        <span class="pl-k">void</span> <span class="pl-en">method</span>() {}
    };
};</pre></div>
<p>So to fix this, consider the whole hierarchy of a tag for choosing its parent, when that information is available from the parser.</p>
<p><span class="issue-keyword tooltipped tooltipped-se" aria-label="This pull request closes issue #1583.">Fixes</span> <a href="https://github.com/geany/geany/issues/1583" class="issue-link js-issue-link" data-url="https://github.com/geany/geany/issues/1583" data-id="251910160" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#1583</a>.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/geany/geany/pull/1598'>https://github.com/geany/geany/pull/1598</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Fix the symbols tree hierarchy when several tags have the same name</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/geany/geany/pull/1598/files#diff-0">HACKING</a>
    (6)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/geany/geany/pull/1598/files#diff-1">src/symbols.c</a>
    (78)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/geany/geany/pull/1598/files#diff-2">src/tagmanager/tm_tag.c</a>
    (41)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/geany/geany/pull/1598/files#diff-3">src/tagmanager/tm_tag.h</a>
    (2)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/geany/geany/pull/1598.patch'>https://github.com/geany/geany/pull/1598.patch</a></li>
  <li><a href='https://github.com/geany/geany/pull/1598.diff'>https://github.com/geany/geany/pull/1598.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1598">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ8mF32Pg1MCLUacJDSZj5a3o8E9Oks5seKK7gaJpZM4PKvxv">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ4Rfhpu_TyLFxjcuM_qPFVNcZ5Usks5seKK7gaJpZM4PKvxv.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1598"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Fix the symbols tree hierarchy when several tags have the same name (#1598)"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1598"}}}</script>