<p><b>@LarsGit223</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/geany/geany-plugins/pull/598#discussion_r134114078">workbench/icons/Makefile.am</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,20 @@
+icondir = $(datadir)/icons/hicolor/16x16/apps
</pre>
<p>I had a look again and changed my opinion: the directories in geany look clean and simple so I tried starting to do it that way, <a href="https://github.com/codebrainz" class="user-mention">@codebrainz</a>: thanks for the link.</p>
<p>But I can't get it to work. In <code>workbench/icons/Makefile.am</code> I have put:</p>
<pre><code>SUBDIRS = 16x16
#24x24 32x32 48x48 scalable tango
gtk_update_icon_cache = gtk-update-icon-cache -f -t
install-data-hook:
@-if test -z "$(DESTDIR)"; then \
echo "Updating Gtk icon cache."; \
$(gtk_update_icon_cache) "$(datadir)/icons/hicolor"; \
$(gtk_update_icon_cache) "$(datadir)/icons/Tango"; \
else \
echo "*** Icon cache not updated. Remember to run:"; \
echo "***"; \
echo "*** $(gtk_update_icon_cache) '$(datadir)/icons/hicolor'";\
echo "*** $(gtk_update_icon_cache) '$(datadir)/icons/Tango'";\
echo "***"; \
fi
uninstall-local:
rm -f $(DESTDIR)$(datadir)/icons/hicolor/icon-theme.cache
rm -f $(DESTDIR)$(datadir)/icons/Tango/icon-theme.cache
</code></pre>
<p>Right now I started with the original icons only, so only subdir <code>16x16</code> is used. In <code>workbench/icons/16x16/Makefile.am</code> I have put:</p>
<pre><code>iconsdir = $(datadir)/icons/hicolor/16x16
icons_appsdir = $(iconsdir)/apps
dist_icons_apps_DATA = \
workbench-bookmark.png \
workbench-dir.png \
workbench-nodirs.png \
workbench-project.png \
workbench-project-error.png
</code></pre>
<p>But when I call <code>make</code> I get the following error:</p>
<pre><code>Making all in src
make[1]: Entering directory '/home/lars/DokuWiki/repos/gp-branch-workbench2/geany-plugins/workbench/src'
make[1]: Nothing to be done for 'all'.
make[1]: Leaving directory '/home/lars/DokuWiki/repos/gp-branch-workbench2/geany-plugins/workbench/src'
Making all in icons
make[1]: Entering directory '/home/lars/DokuWiki/repos/gp-branch-workbench2/geany-plugins/workbench/icons'
cd ../.. && /bin/bash /home/lars/DokuWiki/repos/gp-branch-workbench2/geany-plugins/missing automake-1.15 --foreign workbench/icons/Makefile
cd ../.. && /bin/bash ./config.status workbench/icons/Makefile
config.status: creating workbench/icons/Makefile
Making all in 16x16
make[2]: Entering directory '/home/lars/DokuWiki/repos/gp-branch-workbench2/geany-plugins/workbench/icons/16x16'
make[2]: *** No rule to make target 'all'. Stop.
make[2]: Leaving directory '/home/lars/DokuWiki/repos/gp-branch-workbench2/geany-plugins/workbench/icons/16x16'
Makefile:509: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/home/lars/DokuWiki/repos/gp-branch-workbench2/geany-plugins/workbench/icons'
Makefile:578: recipe for target 'all-recursive' failed
make: *** [all-recursive] Error 1
</code></pre>
<p>So everything looks fine until the point where directory <code>16x16</code> is entered. I know make but not automake and also not the details of the geany makefile. I do not see any target in the original geany 16x16/Makefile.am so I wonder why it's not working.</p>
<p>I need some help here please.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany-plugins/pull/598#discussion_r134114078">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ4uItpZ_Enn5n2BtI8sWLH2h3K05ks5saCXQgaJpZM4O391f">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ63wO42Fr3TEyDB8btGQOxGoM8V7ks5saCXQgaJpZM4O391f.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/geany/geany-plugins/pull/598#discussion_r134114078"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany-plugins","title":"geany/geany-plugins","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany-plugins"}},"updates":{"snippets":[{"icon":"PERSON","message":"@LarsGit223 commented on #598"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany-plugins/pull/598#discussion_r134114078"}}}</script>