<p><b>@b4n</b> requested changes on this pull request.</p>
<p>A few problems, with proposed fixes in <a href="https://github.com/b4n/geany-plugins/tree/LarsGit223/workbench%2Bfollow-up">https://github.com/b4n/geany-plugins/tree/LarsGit223/workbench%2Bfollow-up</a></p><hr>
<p>In <a href="https://github.com/geany/geany-plugins/pull/598#discussion_r134141416">workbench/icons/24x24/Makefile.am</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,9 @@
+iconsdir = $(datadir)/icons/hicolor/16x16
</pre>
<p>wrong target directory, should be <code>24x24</code></p>
<hr>
<p>In <a href="https://github.com/geany/geany-plugins/pull/598#discussion_r134141437">workbench/icons/32x32/Makefile.am</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,9 @@
+iconsdir = $(datadir)/icons/hicolor/16x16
</pre>
<p>should be <code>32x32</code></p>
<hr>
<p>In <a href="https://github.com/geany/geany-plugins/pull/598#discussion_r134141449">workbench/icons/48x48/Makefile.am</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,9 @@
+iconsdir = $(datadir)/icons/hicolor/16x16
</pre>
<p>Should be <code>48x48</code></p>
<hr>
<p>In <a href="https://github.com/geany/geany-plugins/pull/598#discussion_r134141464">workbench/icons/scalable/Makefile.am</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,9 @@
+iconsdir = $(datadir)/icons/hicolor/16x16
</pre>
<p>should be <code>scalable</code></p>
<hr>
<p>In <a href="https://github.com/geany/geany-plugins/pull/598#discussion_r134141727">workbench/src/sidebar.c</a>:</p>
<pre style='color:#555'>> + /**** tree view ****/
+
+ sidebar.file_view = gtk_tree_view_new();
+ g_signal_connect(sidebar.file_view, "row-activated", (GCallback)sidebar_filew_view_on_row_activated, NULL);
+
+ sidebar.file_store = gtk_tree_store_new(FILEVIEW_N_COLUMNS, G_TYPE_ICON, G_TYPE_STRING, G_TYPE_UINT, G_TYPE_POINTER);
+ gtk_tree_view_set_model(GTK_TREE_VIEW(sidebar.file_view), GTK_TREE_MODEL(sidebar.file_store));
+
+ renderer = gtk_cell_renderer_pixbuf_new();
+ column = gtk_tree_view_column_new();
+ gtk_tree_view_column_pack_start(column, renderer, FALSE);
+ gtk_tree_view_column_add_attribute(column, renderer, "gicon", FILEVIEW_COLUMN_ICON);
+
+ renderer = gtk_cell_renderer_text_new();
+ gtk_tree_view_column_pack_start(column, renderer, TRUE);
+ gtk_tree_view_column_add_attribute(column, renderer, "markup", FILEVIEW_COLUMN_NAME);
</pre>
<p>you should use <code>"text"</code>" instead of <code>"markup"</code> as you pass raw filenames (and don't seem to need the markup features), otherwise it'll break with filenames containing <code>&</code>s, <code><</code>s and the like.</p>
<hr>
<p>In <a href="https://github.com/geany/geany-plugins/pull/598#discussion_r134141786">workbench/src/wb_project.c</a>:</p>
<pre style='color:#555'>> +}
+
+
+/* Get the list of files for root */
+static GSList *wb_project_dir_get_file_list(WB_PROJECT_DIR *root, const gchar *utf8_path, GSList *patterns,
+ GSList *ignored_dirs_patterns, GSList *ignored_file_patterns, GHashTable *visited_paths)
+{
+ GSList *list = NULL;
+ GDir *dir;
+ gchar *locale_path = utils_get_locale_from_utf8(utf8_path);
+ gchar *real_path = tm_get_real_path(locale_path);
+
+ dir = g_dir_open(locale_path, 0, NULL);
+ if (!dir || !real_path || g_hash_table_lookup(visited_paths, real_path))
+ {
+ g_dir_close(dir);
</pre>
<p>you should guard this call against <code>NULL</code> <code>dir</code></p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany-plugins/pull/598#pullrequestreview-57398419">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ09Rxdrw2KXupkF_o9qSnSWHIVlPks5saQD8gaJpZM4O391f">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ4zAth_mdsVbDao_IydLgy2zy9DZks5saQD8gaJpZM4O391f.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/geany/geany-plugins/pull/598#pullrequestreview-57398419"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany-plugins","title":"geany/geany-plugins","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany-plugins"}},"updates":{"snippets":[{"icon":"PERSON","message":"@b4n requested changes on #598"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany-plugins/pull/598#pullrequestreview-57398419"}}}</script>