<p><b>@b4n</b> requested changes on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany-plugins/pull/598#discussion_r134103654">po/be.po</a>:</p>
<pre style='color:#555'>> @@ -3405,7 +3405,7 @@ msgstr ""
 msgid "Toggle Insert/Overwrite mode"
</pre>
<p>There is no relevant changes in this file</p>

<hr>

<p>In <a href="https://github.com/geany/geany-plugins/pull/598#discussion_r134103664">po/ca.po</a>:</p>
<pre style='color:#555'>> @@ -3344,7 +3344,7 @@ msgstr "Cancel·la la la Selecció"
 msgid "Toggle Insert/Overwrite mode"
</pre>
<p>Nor in this one (and probably quite a few translation files)</p>

<hr>

<p>In <a href="https://github.com/geany/geany-plugins/pull/598#discussion_r134103698">workbench/src/menu.c</a>:</p>
<pre style='color:#555'>> +
+
+/** Setup the workbench menu.
+ *
+ **/
+gboolean menu_init(void)
+{
+       /* Create menu and root item/label */
+       menu_data.menu = gtk_menu_new();
+       menu_data.root_item = gtk_menu_item_new_with_label(_("Workbench"));
+       gtk_widget_show(menu_data.root_item);
+
+       /* Create new menu item "New Workbench" */
+       menu_data.item_new = gtk_menu_item_new_with_mnemonic(_("_New"));
+       gtk_widget_show(menu_data.item_new);
+       gtk_menu_append(GTK_MENU (menu_data.menu), menu_data.item_new);
</pre>
<p><a href="https://developer.gnome.org/gtk2/stable/GtkMenu.html#gtk-menu-append"><code>gtk_menu_append()</code></a> is deprecated for a long time in favor to <a href="https://developer.gnome.org/gtk2/stable/GtkMenuShell.html#gtk-menu-shell-append"><code>gtk_menu_shell_append()</code></a>, and its use <a href="https://travis-ci.org/geany/geany-plugins/jobs/266322308#L4962">breaks compilation under GTK3</a> which removed the former.</p>

<hr>

<p>In <a href="https://github.com/geany/geany-plugins/pull/598#discussion_r134103715">workbench/src/sidebar.c</a>:</p>
<pre style='color:#555'>> +} MatchType;
+
+typedef struct
+{
+       GeanyProject *project;
+       GPtrArray *expanded_paths;
+} ExpandData;
+
+typedef struct SIDEBAR
+{
+    GtkWidget *file_view_vbox;
+    GtkWidget *file_view;
+    GtkTreeStore *file_store;
+    GtkWidget *file_view_label;
+}SIDEBAR;
+static SIDEBAR sidebar = {NULL, NULL, NULL, NULL, NULL};
</pre>
<p><a href="https://travis-ci.org/geany/geany-plugins/jobs/266322308#L4946">Excess initializer</a> (there are 4 fields, and you initialize 5).</p>

<hr>

<p>In <a href="https://github.com/geany/geany-plugins/pull/598#discussion_r134103754">workbench/src/sidebar.c</a>:</p>
<pre style='color:#555'>> +    gtk_tree_view_column_pack_start(column, renderer, FALSE);
+       gtk_tree_view_column_add_attribute(column, renderer, "gicon", FILEVIEW_COLUMN_ICON);
+
+       renderer = gtk_cell_renderer_text_new();
+       gtk_tree_view_column_pack_start(column, renderer, TRUE);
+       gtk_tree_view_column_add_attribute(column, renderer, "markup", FILEVIEW_COLUMN_NAME);
+
+       gtk_tree_view_append_column(GTK_TREE_VIEW(sidebar.file_view), column);
+
+       gtk_tree_view_set_headers_visible(GTK_TREE_VIEW(sidebar.file_view), FALSE);
+       gtk_tree_view_set_enable_search(GTK_TREE_VIEW(sidebar.file_view), TRUE);
+       gtk_tree_view_set_search_column(GTK_TREE_VIEW(sidebar.file_view), FILEVIEW_COLUMN_NAME);
+
+       pfd = pango_font_description_from_string(wb_globals.geany_plugin->geany_data->interface_prefs->tagbar_font);
+       gtk_widget_modify_font(sidebar.file_view, pfd);
+       pango_font_description_free(pfd);
</pre>
<p>you could use <code>ui_widget_modify_font_from_string()</code> from Geany's utility function (which also would avoid the <a href="https://travis-ci.org/geany/geany-plugins/jobs/266322308#L4954">GTK3 deprecation warning</a>)</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany-plugins/pull/598#pullrequestreview-57361088">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ5kvXSXKAKaTOqkGwEyCQgRKKkKYks5sZ4HTgaJpZM4O391f">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ6bng7tQmAFQqzfKsNtIYFmeFzwhks5sZ4HTgaJpZM4O391f.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany-plugins/pull/598#pullrequestreview-57361088"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany-plugins","title":"geany/geany-plugins","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany-plugins"}},"updates":{"snippets":[{"icon":"PERSON","message":"@b4n requested changes on #598"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany-plugins/pull/598#pullrequestreview-57361088"}}}</script>