<p><b>@b4n</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/1561#discussion_r129733452">src/editor.c</a>:</p>
<pre style='color:#555'>> @@ -2475,6 +2474,7 @@ void editor_insert_text_block(GeanyEditor *editor, const gchar *text, gint inser
                /* count indent size up to insert_pos instead of asking sci
                 * because there may be spaces after it */
                gchar *tmp = sci_get_line(sci, line_start);
+               gint idx;
 
                idx = insert_pos - sci_get_position_from_line(sci, line_start);
</pre>
<blockquote>
<p>I know it's not changed by this PR, but should the assertion above (L2465) be <code>g_return_if_fail(insert_pos > 0);</code> instead […]?</p>
</blockquote>
<p>Why is that?  Isn't 0 the first position in the buffer, like for inserting at the very start?</p>
<p>Otherwise yeah this code could get a little more validation indeed.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1561#discussion_r129733452">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ9-CVmju4phO8bLVyYYjMA6flNamks5sR-JGgaJpZM4OkdhJ">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJzIWI--vntu89-mRYfNAi426KKfAks5sR-JGgaJpZM4OkdhJ.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1561#discussion_r129733452"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@b4n commented on #1561"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1561#discussion_r129733452"}}}</script>