Am 15. Juli 2017 08:04:42 MESZ schrieb elextr <notifications@github.com>:<br>
>@kugel-  NULL `doc` is only prevented from something hidden in the<br>
>context, in this case UI sensitivity.  The `doc` pointer may be NULL<br>
>and yes you are correct, the `doc->file_name` can be NULL.<br>
><br>
>Geany is nowhere near exhaustively tested to be able to have some<br>
>reasonable guarantee that asserts will not be hit by users, so we<br>
>should not be inserting crashers like assert in the code.  Just provide<br>
>a message if you must using the Glib logging capability that is already<br>
>set up in Geany, but otherwise the original `if(doc && doc->file_name)`<br>
>is file.<br>
><br>
>-- <br>
>You are receiving this because you were mentioned.<br>
>Reply to this email directly or view it on GitHub:<br>
>https://github.com/geany/geany/pull/1537#issuecomment-315512679<br>
<br>
Whatever works. 3/4 devs with 3/4 opinions discussing over a tiny change like this is discouraging and not fruitful. 

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1537#issuecomment-315513242">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ5Fojo5jE1x55A9sEfcMbxohxOaBks5sOFksgaJpZM4OR0zM">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ7pCgyivIylQTXpvsKVrgo5I15apks5sOFksgaJpZM4OR0zM.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1537#issuecomment-315513242"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@kugel- in #1537: Am 15. Juli 2017 08:04:42 MESZ schrieb elextr \u003cnotifications@github.com\u003e:\n\u003e@kugel-  NULL `doc` is only prevented from something hidden in the\n\u003econtext, in this case UI sensitivity.  The `doc` pointer may be NULL\n\u003eand yes you are correct, the `doc-\u003efile_name` can be NULL.\n\u003e\n\u003eGeany is nowhere near exhaustively tested to be able to have some\n\u003ereasonable guarantee that asserts will not be hit by users, so we\n\u003eshould not be inserting crashers like assert in the code.  Just provide\n\u003ea message if you must using the Glib logging capability that is already\n\u003eset up in Geany, but otherwise the original `if(doc \u0026\u0026 doc-\u003efile_name)`\n\u003eis file.\n\u003e\n\u003e-- \n\u003eYou are receiving this because you were mentioned.\n\u003eReply to this email directly or view it on GitHub:\n\u003ehttps://github.com/geany/geany/pull/1537#issuecomment-315512679\n\nWhatever works. 3/4 devs with 3/4 opinions discussing over a tiny change like this is discouraging and not fruitful. "}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1537#issuecomment-315513242"}}}</script>