<p>Agree with everybody, <a href="https://github.com/kugel-" class="user-mention">@kugel-</a> is right the doc == NULL test is not <em>required</em> with the current Geany, agree with <a href="https://github.com/vfaronov" class="user-mention">@vfaronov</a> that the name test is still required, agree with <a href="https://github.com/codebrainz" class="user-mention">@codebrainz</a> that telling the devs about a coding error is a not a bad idea (though perhaps not by crashing the application as assert does, its not a fatal error as its currently coded).</p>
<p>But ultimately I don't think it matters for this PR.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1537#issuecomment-315312246">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ-IH9IRSvVnjOKC7IWydtwk0Ey3Xks5sNzFfgaJpZM4OR0zM">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ5uSxyy5Y8uzjkzsi_u1ISWgdoITks5sNzFfgaJpZM4OR0zM.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1537#issuecomment-315312246"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@elextr in #1537: Agree with everybody, @kugel- is right the doc == NULL test is not _required_ with the current Geany, agree with @vfaronov that the name test is still required, agree with @codebrainz that telling the devs about a coding error is a not a bad idea (though perhaps not by crashing the application as assert does, its not a fatal error as its currently coded).\r\n\r\nBut ultimately I don't think it matters for this PR."}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1537#issuecomment-315312246"}}}</script>