<blockquote>
<p>I still do not quite understand how an assertion would be useful here, so I chose not to add it; hope that’s OK.</p>
</blockquote>
<p>As I said, I don't think the <code>NULL</code> check for <code>doc</code> is even harmful (ie. the original code was fine), but <a href="https://github.com/kugel-" class="user-mention">@kugel-</a> didn't think it was necessary and you did. An assertion here gives the best of both cases, it checks the precondition you were checking originally (in case a caller calls it with no documents open), but it compiles away to nothing for release builds since it's impossible to fire during a correct run (ie. the GUI prevents it). For more information <a href="https://en.wikipedia.org/wiki/Assertion_(software_development)#Assertions_during_the_development_cycle">see here</a></p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1537#issuecomment-315494677">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ8vwSpVE_wi4f8SXnocvXuW0orF4ks5sOAL5gaJpZM4OR0zM">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ-u539pGF3JQVSijaibJOJcT9Owiks5sOAL5gaJpZM4OR0zM.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1537#issuecomment-315494677"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@codebrainz in #1537: \u003e I still do not quite understand how an assertion would be useful here, so I chose not to add it; hope that’s OK.\r\n\r\nAs I said, I don't think the `NULL` check for `doc` is even harmful (ie. the original code was fine), but @kugel- didn't think it was necessary and you did. An assertion here gives the best of both cases, it checks the precondition you were checking originally (in case a caller calls it with no documents open), but it compiles away to nothing for release builds since it's impossible to fire during a correct run (ie. the GUI prevents it). For more information [see here](https://en.wikipedia.org/wiki/Assertion_(software_development)#Assertions_during_the_development_cycle)"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1537#issuecomment-315494677"}}}</script>