<p>Consider the following C document:</p>
<pre><code>int foo(void)
{
    return bar(123);
}

int bar(int n)
{
    return n + 1;
}
</code></pre>
<p><strong>Scenario 1.</strong> Place the cursor on line 3, column 12, and invoke <em>Go to Symbol Definition</em>. The cursor jumps to line 6, column 0. Now invoke <em>Navigate back a location</em>. The cursor jumps to 3,12 — just what you’d expect.</p>
<p><strong>Scenario 2.</strong> Place the cursor on line 3, column 12, and invoke <em>Go to Symbol Definition</em>. The cursor jumps to line 6, column 0. Now move the cursor manually to line 8, column 15, and then invoke <em>Navigate back a location</em>. Again, the cursor jumps to 3,12. Is this what you’d expect? Depends; but clearly there are cases where you’d prefer to jump to 6,0 first. In addition, you can’t <em>Navigate forward a location</em> to 8,15.</p>
<p>This PR changes <em>Navigate back a location</em> so that it first pushes the current position onto the navqueue. This does not affect scenario 1, because the navqueue’s <code>add_new_position</code> deduplicates positions at the head. But in scenario 2, this has the effect that <em>Navigate back</em> takes you to 6,0 first. If you want 3,12, it’s just one more <em>Navigate back</em> away. And you can <em>Navigate forward</em> to 8,15 now.</p>
<p>I have realized over time that this is kind of a prerequisite for my PR <a href="https://github.com/geany/geany/pull/1114" class="issue-link js-issue-link" data-url="https://github.com/geany/geany/issues/1114" data-id="163641252" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#1114</a>. Otherwise it is very counter-intuitive that <em>Navigate back</em> does <strong>not</strong> take you to the position you just pushed with <em>Remember location in history</em>.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/geany/geany/pull/1537'>https://github.com/geany/geany/pull/1537</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Push current position to navqueue before navigating back</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/geany/geany/pull/1537/files#diff-0">src/navqueue.c</a>
    (8)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/geany/geany/pull/1537.patch'>https://github.com/geany/geany/pull/1537.patch</a></li>
  <li><a href='https://github.com/geany/geany/pull/1537.diff'>https://github.com/geany/geany/pull/1537.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1537">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ3yf8PpO_F3JD9Fg2mpjVcyGPofHks5sL8ZqgaJpZM4OR0zM">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ-r5N2zFsZdIr7bddoRhBYCPLyaQks5sL8ZqgaJpZM4OR0zM.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1537"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Push current position to navqueue before navigating back (#1537)"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1537"}}}</script>