<p><b>@b4n</b> commented on this pull request.</p>

<p>This looks good, and useful.  However, which impact does it have on performance for dynamic languages which would likely always ref/unref through the <code>GBoxed</code> API, even when not actually needed.  Or are Python and other GType bridges smarter than that and only copying when really required?</p><hr>

<p>In <a href="https://github.com/geany/geany/pull/1465#discussion_r125787847">src/tagmanager/tm_tag.c</a>:</p>
<pre style='color:#555'>> @@ -82,7 +82,11 @@ typedef struct
        gboolean first;
 } TMSortOptions;
 
-/* Gets the GType for a TMTag */
+/** Gets the GBoxed-derived GType for a TMTag.
</pre>
<p>Should we advertise it's derived from GBoxed?  C code should probably have access to <code>tm_tag_ref()</code>/<code>tm_tag_unref()</code> instead as it has more meaningful semantics as <code>g_boxed_copy()</code>, and generic code can figure it out by itself looking at the type information.<br>
And advertising GBoxed means it's kind of stuck to that implementation -- which is likely to say indeed, so I'm probably nitpicking, but we could want to change that one day.</p>
<p>Anyway, that's not a so important point.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/1465#discussion_r125787896">src/tagmanager/tm_tag.c</a>:</p>
<pre style='color:#555'>> @@ -82,7 +82,11 @@ typedef struct
        gboolean first;
 } TMSortOptions;
 
-/* Gets the GType for a TMTag */
+/** Gets the GBoxed-derived GType for a TMTag.
+ *
+ * @return TMTag type
+ * @since 1.31 (API 232) */
</pre>
<p>unfortunately that probably will have to be updated</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1465#pullrequestreview-48210361">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ6jicUkW4cCA15jwfO7JY4i4j5zgks5sLCmEgaJpZM4M4XZ9">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ-ye6HQ09rDzjEK3fsBA7e0XufmRks5sLCmEgaJpZM4M4XZ9.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1465#pullrequestreview-48210361"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@b4n commented on #1465"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1465#pullrequestreview-48210361"}}}</script>