<p>I'm going to test <code>gtk_show_uri()</code> (and the <code>_on_window</code> variant) on Windows, maybe it works for file:// and http:// URIs even without GVFS what should be well enough for opening URLs in the browser.</p>
<p>I would prepare a PR to do the following:</p>
<ul>
<li>remove the "firefox" default browser on Windows, letting it undefined for Windows</li>
<li>change the behavior to use the configured browser command on Windows for opening URIs</li>
<li>fallback to <code>gtk_show_uri</code> if no browser command is configured (or fallback to <code>ShellExecute</code> if <code>gtk_show_uri</code> does not work)</li>
<li>maybe check for the configured browser command to not equal "firefox" which was the previous default value on Windows which most probably won't work for most users except they added firefox to their $PATH which is unlikely; this would help users with existing configurations</li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/issues/1522#issuecomment-311260432">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ7em_HxhIeITEGXP9ggEIZS_nZdvks5sIJk0gaJpZM4ODKDO">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ08w1uMXnzo0tEM3HDXfw_M8zaiKks5sIJk0gaJpZM4ODKDO.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/issues/1522#issuecomment-311260432"></link>
  <meta itemprop="name" content="View Issue"></meta>
</div>
<meta itemprop="description" content="View this Issue on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@eht16 in #1522: I'm going to test `gtk_show_uri()` (and the `_on_window` variant) on Windows, maybe it works for file:// and http:// URIs even without GVFS what should be well enough for opening URLs in the browser.\r\n\r\nI would prepare a PR to do the following:\r\n- remove the \"firefox\" default browser on Windows, letting it undefined for Windows\r\n- change the behavior to use the configured browser command on Windows for opening URIs\r\n- fallback to `gtk_show_uri` if no browser command is configured (or fallback to `ShellExecute` if `gtk_show_uri` does not work)\r\n- maybe check for the configured browser command to not equal \"firefox\" which was the previous default value on Windows which most probably won't work for most users except they added firefox to their $PATH which is unlikely; this would help users with existing configurations"}],"action":{"name":"View Issue","url":"https://github.com/geany/geany/issues/1522#issuecomment-311260432"}}}</script>