<p><b>@Thannoy</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany-plugins/pull/581#discussion_r122571042">pretty-printer/src/ConfigUI.c</a>:</p>
<pre style='color:#555'>> @@ -118,9 +119,204 @@ void saveSettings(void)
     ppo->indentChar = gtk_combo_box_get_active(GTK_COMBO_BOX(indentationChar))==0 ? '\t' : ' ';
 
     breakStyle = gtk_combo_box_get_active(GTK_COMBO_BOX(lineBreak));
-    if (breakStyle == 0) ppo->newLineChars = "\r";
-    else if (breakStyle == 1) ppo->newLineChars = "\n";
-    else ppo->newLineChars = "\r\n";
+    if (ppo->newLineChars != NULL)
+    {
+        g_free ((gpointer)ppo->newLineChars);
</pre>
<p>(minor) freeing a NULL pointer is perfectly legal. There is no need to test nullity, you can use g_free unconditionally here. (see <a href="https://developer.gnome.org/glib/stable/glib-Memory-Allocation.html#g-free">https://developer.gnome.org/glib/stable/glib-Memory-Allocation.html#g-free</a>)</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany-plugins/pull/581#pullrequestreview-44702661">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ91d6hgdMkYDC1Zv150GDZTaXEvbks5sE_OLgaJpZM4N2Z9m">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ4YU6yxUIOSkQwQaY2XPBW-pu7iFks5sE_OLgaJpZM4N2Z9m.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany-plugins/pull/581#pullrequestreview-44702661"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany-plugins","title":"geany/geany-plugins","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany-plugins"}},"updates":{"snippets":[{"icon":"PERSON","message":"@Thannoy commented on #581"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany-plugins/pull/581#pullrequestreview-44702661"}}}</script>