<p><b>@b4n</b> requested changes on this pull request.</p>

<p>Not tested yet, but looks almost good, see comments.</p><hr>

<p>In <a href="https://github.com/geany/geany/pull/1514#discussion_r121265516">src/editor.h</a>:</p>
<pre style='color:#555'>> @@ -137,6 +137,7 @@ typedef struct GeanyEditorPrefs
        gboolean        long_line_enabled;
        gint            autocompletion_update_freq;
        gint            scroll_lines_around_cursor;
+       gboolean        ime_interaction; /* input method editor's candidate window behaviour */
</pre>
<p>This should be an int and use on of the Scintilla constants, <code>SC_IME_WINDOWED</code> or <code>SC_IME_INLINE</code>, so it can be easily extended in the future, and have a semantic meaning.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/1514#discussion_r121265570">src/keyfile.c</a>:</p>
<pre style='color:#555'>> @@ -255,6 +255,8 @@ static void init_pref_groups(void)
                "extract_filetype_regex", GEANY_DEFAULT_FILETYPE_REGEX);
        stash_group_add_boolean(group, &search_prefs.replace_and_find_by_default,
                "replace_and_find_by_default", TRUE);
+       stash_group_add_boolean(group, &editor_prefs.ime_interaction,
+               "editor_ime_inline", TRUE);
</pre>
<p>Same here, should be</p>
<div class="highlight highlight-source-c"><pre>   <span class="pl-en">stash_group_add_integer</span>(group, &editor_prefs.ime_interaction,
                <span class="pl-s"><span class="pl-pds">"</span>editor_ime_interaction<span class="pl-pds">"</span></span>, SC_IME_WINDOWED);</pre></div>
<p>And better keep the current behavior as default unless we have a compelling set of data that the current default is a problem for everyone.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1514#pullrequestreview-43305226">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ7k_BQn3n1Ag-twzUtHcPGR_SQyrks5sCvvYgaJpZM4N2HgO">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ97r3UwbG8nhs9a7X_1Rf77qOoUTks5sCvvYgaJpZM4N2HgO.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1514#pullrequestreview-43305226"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@b4n requested changes on #1514"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1514#pullrequestreview-43305226"}}}</script>