<p>I just added SCE_RB_STRING_Q* and  SCE_C_USERLITERAL.</p>
<p>What do we want to about the regex styles?<br>
Considering those styles as strings would "break" SpellCheck (provided we change it to use <code>highlighting_is_*_style()</code> instead of its own mapping).<br>
On the other hand, it could help the AutoClose plugin which already uses <code>highlighting_is_code_style</code> to check wether it should close brackets or not and auto-closing brackets in regelar expressions might be confusing.</p>
<p>When SpellCheck would use <code>highlighting_is_*_style()</code> for style checking, it could be OK to add a successor check to treat the regex styles special for the SpellCheck context.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1502#issuecomment-304507367">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJwfzFKugF7MCViCZbsEJ28-vCaPCks5r-VbJgaJpZM4Nmayz">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ7ovJD3TagNvQqEXtZUj6Twkv_2Aks5r-VbJgaJpZM4Nmayz.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1502#issuecomment-304507367"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@eht16 in #1502: I just added SCE_RB_STRING_Q* and  SCE_C_USERLITERAL.\r\n\r\nWhat do we want to about the regex styles?\r\nConsidering those styles as strings would \"break\" SpellCheck (provided we change it to use `highlighting_is_*_style()` instead of its own mapping).\r\nOn the other hand, it could help the AutoClose plugin which already uses `highlighting_is_code_style` to check wether it should close brackets or not and auto-closing brackets in regelar expressions might be confusing.\r\n\r\nWhen SpellCheck would use `highlighting_is_*_style()` for style checking, it could be OK to add a successor check to treat the regex styles special for the SpellCheck context."}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1502#issuecomment-304507367"}}}</script>