<p><a href="https://github.com/attila-v" class="user-mention">@attila-v</a> Thank you for your work! I will try running Geany with this change to see how well it works for me.</p>
<p>So far I see a couple problems.</p>
<p>The first problem is that you still silently lose unsaved changes (in files that have diverged from disk).</p>
<p>The second problem is an assertion error. I can reproduce it as follows:</p>
<ol>
<li>Open some file in Geany.</li>
<li>Delete it from disk.</li>
<li>Switch to Geany. At the top of the document, Geany shows an orange info bar that says: “File ... was not found on disk! Try to resave the file?”</li>
</ol>
<p>With your change, when this orange info bar appears, I see the following in the console:</p>
<pre><code> GtkWarning: IA__gtk_info_bar_add_button: assertion 'button_text != NULL' failed
</code></pre>
<p>Without your change, there is no such warning.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1471#issuecomment-304460143">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ3cdlsqaBBQvU5ejyyKGAX8B12Ylks5r-EZ1gaJpZM4NEjQ4">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ-XTa3fZFBKp2JN8fxVdjpb3oQaHks5r-EZ1gaJpZM4NEjQ4.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1471#issuecomment-304460143"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@vfaronov in #1471: @attila-v Thank you for your work! I will try running Geany with this change to see how well it works for me.\r\n\r\nSo far I see a couple problems.\r\n\r\nThe first problem is that you still silently lose unsaved changes (in files that have diverged from disk).\r\n\r\nThe second problem is an assertion error. I can reproduce it as follows:\r\n\r\n1. Open some file in Geany.\r\n2. Delete it from disk.\r\n3. Switch to Geany. At the top of the document, Geany shows an orange info bar that says: “File ... was not found on disk! Try to resave the file?”\r\n\r\nWith your change, when this orange info bar appears, I see the following in the console:\r\n\r\n     GtkWarning: IA__gtk_info_bar_add_button: assertion 'button_text != NULL' failed\r\n\r\nWithout your change, there is no such warning."}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1471#issuecomment-304460143"}}}</script>