<p><b>@techee</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany-plugins/pull/531#discussion_r116367044">git-changebar/src/gcb-plugin.c</a>:</p>
<pre style='color:#555'>> +
+    if (data->found) {
+      ScintillaObject *sci = doc->editor->sci;
+
+      sci_start_undo_action(sci);
+
+      if (data->new_lines > 0) {
+        gint pos = sci_get_position_from_line(sci, data->new_start - 1);
+        sci_set_target_start(sci, pos);
+        pos = sci_get_position_from_line(sci, data->new_start + data->new_lines - 1);
+        sci_set_target_end(sci, pos);
+        sci_replace_target(sci, "", FALSE);
+      }
+
+      if (data->old_lines > 0) {
+        gint line = sci_get_current_line (sci);
</pre>
<p><code>gint pos = sci_get_position_from_line (sci, data->new_start - 1);</code> returns the pos on the previous line which is wrong when undoing deleted-only diff - I need to advance it to the next line if <code>new_lines == 0</code> (see a few lines below). I could probably get the length of the line and add it to pos in this case.</p>
<p>Just to understand - what does scintilla return from sci_get_current_line() when you right-click somewhere - I'd expect it doesn't change the current line, does it?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany-plugins/pull/531#discussion_r116367044">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJwrl47LYfb3AQ8ILE_JZdu0QkbXIks5r5hepgaJpZM4MFhGb">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ2PyqesTmN7yTMqiiCAF8tlEWQFpks5r5hepgaJpZM4MFhGb.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany-plugins/pull/531#discussion_r116367044"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany-plugins","title":"geany/geany-plugins","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany-plugins"}},"updates":{"snippets":[{"icon":"PERSON","message":"@techee commented on #531"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany-plugins/pull/531#discussion_r116367044"}}}</script>