<p><b>@b4n</b> commented on this pull request.</p>

<p>I didn't yet do any kind of proper review (not even tested it yet), but sounds reasonable and the feature seems great :)</p>
<p>I'll try and make a proper review in the upcoming days if I can get enough Internet (yeah, not sure I'll make it through without any, crossing fingers :]).</p><hr>

<p>In <a href="https://github.com/geany/geany-plugins/pull/531#discussion_r114922592">git-changebar/src/gcb-plugin.c</a>:</p>
<pre style='color:#555'>> @@ -1044,13 +1053,13 @@ goto_next_hunk_diff_hunk_cb (const git_diff_delta *delta,
       if (data->next_line >= 0) {
         return 1;
       } else if (data->line < hunk->new_start - 1) {
-        data->next_line = hunk->new_start - 1;
+        data->next_line = (hunk->new_start == 0) ? 0 : hunk->new_start - 1;
</pre>
<p>maybe it'd be worth creating a function/macro for that, as it's repeated 3 times?  Not sure of a name for it yet though :)</p>

<hr>

<p>In <a href="https://github.com/geany/geany-plugins/pull/531#discussion_r114922651">git-changebar/src/gcb-plugin.c</a>:</p>
<pre style='color:#555'>> +  gint             old_pos_start, old_pos_end;
+  gchar           *old_range;
+  
+  /* convert the buffer to UTF-8 if necessary */
+  if (encoding_needs_coversion (doc->encoding)) {
+    free_buf = convert_encoding_inplace (&old_buf, &old_buf_len, free_buf,
+                                         "UTF-8", doc->encoding, NULL);
+  }
+  
+  scintilla_send_message (old_sci, SCI_ADDTEXT, old_buf_len, (glong) old_buf);
+
+  old_pos_start = sci_get_position_from_line (old_sci, old_start);
+  old_pos_end = sci_get_position_from_line (old_sci, old_start + old_lines);
+  old_range = sci_get_contents_range (old_sci, old_pos_start, old_pos_end);
+
+  sci_insert_text(doc->editor->sci, pos, old_range);
</pre>
<p>style: space before the open parenthesis</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany-plugins/pull/531#pullrequestreview-36425261">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ07aJY4W3iF4eNrxQ2CMLUZ2RUb0ks5r2oSJgaJpZM4MFhGb">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ4E0_A2kjGdgbBqifT3GFhrM_Whzks5r2oSJgaJpZM4MFhGb.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany-plugins/pull/531#pullrequestreview-36425261"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany-plugins","title":"geany/geany-plugins","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany-plugins"}},"updates":{"snippets":[{"icon":"PERSON","message":"@b4n commented on #531"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany-plugins/pull/531#pullrequestreview-36425261"}}}</script>