<p>Agree with <a href="https://github.com/vfaronov" class="user-mention">@vfaronov</a> that only files that have changed on disk should be reloaded, reloading other files just wastes time and wastes memory keeping the undo buffer for them.  And even more importantly only reload files that do not have unsaved changes in the buffer, silently appearing to lose users changes is not acceptable.</p>
<p><a href="https://github.com/vfaronov" class="user-mention">@vfaronov</a> I am not sure that one all or nothing dialog is the right way, maybe it should have a checklist of which to reload or otherwise it should be a separate dialog per file.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1471#issuecomment-298200518">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ7SQAngfjY1OsbFQT5-gs9oz4XC2ks5r08WkgaJpZM4NEjQ4">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ3tOMU6Kpw8RGK4DDrvFipj9qstbks5r08WkgaJpZM4NEjQ4.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1471#issuecomment-298200518"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@elextr in #1471: Agree with @vfaronov that only files that have changed on disk should be reloaded, reloading other files just wastes time and wastes memory keeping the undo buffer for them.  And even more importantly only reload files that do not have unsaved changes in the buffer, silently appearing to lose users changes is not acceptable.\r\n\r\n@vfaronov I am not sure that one all or nothing dialog is the right way, maybe it should have a checklist of which to reload or otherwise it should be a separate dialog per file."}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1471#issuecomment-298200518"}}}</script>