<p>ok, there are two ways of looking at this:</p>
<ol>
<li>
<p>no visible code uses it, and no other reports of the problem, and since <a href="https://github.com/techee" class="user-mention">@techee</a> already has the fix there is no rush to commit this and it can be committed when <a href="https://github.com/techee" class="user-mention">@techee</a> publishes his super-plugin</p>
</li>
<li>
<p>since this function is effectively part of the code of <code>plugin_set_key_group()</code> (which is the only user, so the fix cannot affect other code, by inspection), and that is in the API, the bug report should be fixed before anyone else uses it</p>
</li>
</ol>
<p>I incline to the second view, so it nobody objects within a few days will commit it.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1426#issuecomment-291306621">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ57mYeTKbLQhjPzaMW977Ab3O6gjks5rsXwfgaJpZM4Magzv">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJwWFDKw9wfAwbRcXpNTRTF7uIiEUks5rsXwfgaJpZM4Magzv.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1426#issuecomment-291306621"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@elextr in #1426: ok, there are two ways of looking at this:\r\n\r\n1) no visible code uses it, and no other reports of the problem, and since @techee already has the fix there is no rush to commit this and it can be committed when @techee publishes his super-plugin\r\n\r\n2) since this function is effectively part of the code of `plugin_set_key_group()` (which is the only user, so the fix cannot affect other code, by inspection), and that is in the API, the bug report should be fixed before anyone else uses it\r\n\r\nI incline to the second view, so it nobody objects within a few days will commit it."}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1426#issuecomment-291306621"}}}</script>