<p><b>@codebrainz</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/1445#discussion_r107810545">src/utils.c</a>:</p>
<pre style='color:#555'>> + */
+static gchar *utils_strv_find_common_prefix(gchar **strv, size_t num)
+{
+       gchar *prefix, **ptr;
+
+       if (!NZV(strv))
+               return NULL;
+
+       if (num == 0)
+               num = g_strv_length(strv);
+
+       prefix = g_strdup(strv[0]);
+
+       for (gint i = 0; prefix[i]; i++)
+       {
+               foreach_strv(ptr, &strv[1])
</pre>
<p>Guessing it's accidental since it's indented wrong and missing braces, and <code>strv</code> can be less than two elements long and not necessarily nul-terminated.</p>
<p>A bit off-topic but what does this weird macro do compared to the normal C code <code>for (GStrv ptr = strv+1; *ptr; ptr++)</code>?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1445#discussion_r107810545">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJz8P_KvF513jidv-PANnJQsLYtk-ks5rowVvgaJpZM4MnYrc">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJzw3oyteBx5GmfHL7YFcke5seivLks5rowVvgaJpZM4MnYrc.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1445#discussion_r107810545"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@codebrainz commented on #1445"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1445#discussion_r107810545"}}}</script>