<p><b>@elextr</b> approved this pull request.</p>

<p><a href="https://github.com/kugel-" class="user-mention">@kugel-</a> sorry I give up reviewing this, can't figure out the G* macro shit.  Will approve so someone else can review it.</p><hr>

<p>In <a href="https://github.com/geany/geany/pull/1445#discussion_r107799413">src/utils.c</a>:</p>
<pre style='color:#555'>> + */
+static gchar *utils_strv_find_common_prefix(gchar **strv, size_t num)
+{
+       gchar *prefix, **ptr;
+
+       if (!NZV(strv))
+               return NULL;
+
+       if (num == 0)
+               num = g_strv_length(strv);
+
+       prefix = g_strdup(strv[0]);
+
+       for (gint i = 0; prefix[i]; i++)
+       {
+               foreach_strv(ptr, &strv[1])
</pre>
<p>why is this here?</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/1445#discussion_r107799563">src/utils.c</a>:</p>
<pre style='color:#555'>> @@ -2031,6 +2031,199 @@ gchar **utils_strv_join(gchar **first, gchar **second)
        return strv;
 }
 
+/* * Returns the common prefix in a list of strings.
+ *
+ * The size of the list may be given explicitely automatically determined if passed a GStrv.
</pre>
<p>what you actually mean is a null terminated pointer array, GStrv is just a char**.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/1445#discussion_r107799957">src/utils.c</a>:</p>
<pre style='color:#555'>> +            if (prefix[i] == '\0')
+                       break;
+       }
+       return prefix;
+}
+
+/* * Returns the common prefix in a list of strings.
+ *
+ * The size of the list may be given explicitely automatically determined if passed a GStrv.
+ *
+ * @param strv The list of strings to process.
+ * @param num The number of strings contained in @a strv. Can be 0 if @a strv is a @c GStrv
+ *
+ * @return The common prefix that is part of all strings.
+ */
+gchar *utils_strv_find_lcs(gchar **strv, size_t num)
</pre>
<p>whats the difference between this and the previous function</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1445#pullrequestreview-28793662">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ0Wz2geWDFwE7Uk3armyMA6fmd8Vks5rovwagaJpZM4MnYrc">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ2q2Kr0-3dQ742G8KoOMDbfK3cICks5rovwagaJpZM4MnYrc.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1445#pullrequestreview-28793662"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@elextr approved #1445"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1445#pullrequestreview-28793662"}}}</script>