<p><b>@b4n</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/1427#discussion_r106781231">m4/geany-criterion.m4</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,10 @@
+dnl Checks for everything required for criterion unit tests
+AC_DEFUN([GEANY_CHECK_CRITERION],
+[
+       AC_REQUIRE_AUX_FILE([tap-driver.sh])
+       AC_PROG_AWK
+
+       PKG_CHECK_MODULES([CRITERION], [criterion >= 2.3.1],
+                       [AM_CONDITIONAL([WITH_CRITERION], true)],
+                       [AM_CONDITIONAL([WITH_CRITERION], false)])
</pre>
<p><a href="https://www.gnu.org/software/automake/manual/automake.html#Usage-of-Conditionals">https://www.gnu.org/software/automake/manual/automake.html#Usage-of-Conditionals</a></p>
<blockquote>
<p>The shell <em>condition</em> (suitable for use in a shell <code>if</code> statement) is evaluated when <code>configure</code> is run. Note that you must arrange for every <code>AM_CONDITIONAL</code> to be invoked every time configure is run. <strong>If <code>AM_CONDITIONAL</code> is run conditionally (e.g., in a shell <code>if</code> statement), then the result will confuse <code>automake</code>.</strong></p>
</blockquote>
<p>I'm not sure it's the issue, and I get that it's supposed to be run anyway (and we have similar double conditionals), yet <em>this might be cached</em>, in which case I'm not completely sure of what runs and what doesn't.<br>
I'd try the obvious way to move the condition outside and do something like</p>
<pre><code class="language-m4">   PKG_CHECK_MODULES([CRITERION], [criterion >= 2.3.1],
                          [with_criterion=yes], [with_criterion=no])
        AM_CONDITIONAL([WITH_CRITERION], [test "x$with_criterion" = xyes])
</code></pre>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1427#pullrequestreview-27724702">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ3wqB_SJw-mitCO6VvF6zKX4f8Dtks5rm-A0gaJpZM4Ma5hm">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ_8-L6atBqPaMNo_x9kXA15t_Deaks5rm-A0gaJpZM4Ma5hm.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1427#pullrequestreview-27724702"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@b4n commented on #1427"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1427#pullrequestreview-27724702"}}}</script>