<p><b>@b4n</b> commented on this pull request.</p>

<p>Looks good apart from the unnecessary allocations.</p>
<p>Also, I'm find with depending on <a href="https://github.com/techee" class="user-mention">@techee</a>'s PR, so you can drop the first commit if you want.</p><hr>

<p>In <a href="https://github.com/geany/geany-plugins/pull/517#discussion_r101922008">lineoperations/src/lineoperations.c</a>:</p>
<pre style='color:#555'>>      gint   num_chars      = 0;
        gint   i              = 0;
        gint   lines_affected = 0;
 
+       struct lo_lines *sel = g_malloc(sizeof(struct lo_lines));
</pre>
<p>instead of allocating on the heap you could pass <code>&sel</code> to the <code>get_current_sel_lines()</code> call below</p>

<hr>

<p>In <a href="https://github.com/geany/geany-plugins/pull/517#discussion_r101922019">lineoperations/src/lineoperations.c</a>:</p>
<pre style='color:#555'>> @@ -223,18 +227,26 @@ action_sci_manip_item(GtkMenuItem *menuitem, gpointer gdata)
        /* function pointer to gdata -- function to be used */
        gint (*func)(ScintillaObject *, gint, gint) = gdata;
        GeanyDocument *doc  = document_get_current();
-       struct lo_lines sel = get_current_sel_lines(doc->editor->sci);
+
+       struct lo_lines *sel = g_malloc(sizeof(struct lo_lines));
</pre>
<p>ditto</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany-plugins/pull/517#pullrequestreview-22663334">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ2Arsttmct-UU-IuJXMQIy-suwvEks5reG5KgaJpZM4LhW2J">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ4d1H-GILSZdxPb7RI8SRFpBBoffks5reG5KgaJpZM4LhW2J.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany-plugins/pull/517#pullrequestreview-22663334"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany-plugins","title":"geany/geany-plugins","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany-plugins"}},"updates":{"snippets":[{"icon":"PERSON","message":"@b4n commented on #517"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany-plugins/pull/517#pullrequestreview-22663334"}}}</script>