<p><b>@b4n</b> approved this pull request.</p>

<p>:LGTM:</p><hr>

<p>In <a href="https://github.com/geany/geany-plugins/pull/527#discussion_r101752910">geanypy/src/Makefile.am</a>:</p>
<pre style='color:#555'>>                                                              -DGEANYPY_PYTHON_DIR="\"$(libdir)/geany/geanypy\"" \
                                                                -DGEANYPY_PLUGIN_DIR="\"$(libdir)/geany\"" \
                                                                -DG_LOG_DOMAIN=\"GeanyPy\"
-geanypy_la_CFLAGS                      =       @GEANYPY_CFLAGS@ @GMODULE_CFLAGS@
+geanypy_la_CFLAGS                      =       @PYGTK_CFLAGS@ @GEANY_CFLAGS@ @GEANYPY_CFLAGS@ @GMODULE_CFLAGS@
</pre>
<p>I don't think this changes matters much, but IMO it's not bad, rather good.  Yes, <em>pkg-config</em> will mostly fill the <code>*_CFLAGS</code> variable with preprocessor flags, but it might put other stuff here if it wants.  Also, it's fine putting preprocessor flags in <code>*_CFLAGS</code> AFAIK, only library order matters.</p>

<hr>

<p>In <a href="https://github.com/geany/geany-plugins/pull/527#discussion_r101753492">geanypy/src/geanypy-editor.c</a>:</p>
<pre style='color:#555'>> @@ -62,7 +62,7 @@ Editor_get_property(Editor *self, const gchar *prop_name)
                PyObject *py_doc;
                py_doc = (PyObject *) Document_create_new_from_geany_document(
                                                                        self->editor->document);
-               if (py_doc && py_doc != Py_None)
+               if (!py_doc || py_doc == Py_None)
</pre>
<p>Agreed, the previous one seems weird: returning <code>None</code> when <code>py_doc</code> is <em>not</em> <code>NULL</code> or <code>None</code>?  weird.</p>
<p>New condition seems more reasonable to me.  I wonder if <code>Py_RETURN_NONE</code> is different than <code>return Py_None</code>, but it doesn't change anything.</p>

<hr>

<p>In <a href="https://github.com/geany/geany-plugins/pull/527#discussion_r101753614">geanypy/src/geanypy-glog.c</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,45 @@
+#if defined(HAVE_CONFIG_H) && !defined(GEANYPY_WINDOWS)
</pre>
<p>no license header?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany-plugins/pull/527#pullrequestreview-22491553">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ9-6Jilqyh_vOTiclQtqg0aRPwrZks5rdZ4DgaJpZM4MD5P7">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJz7qDelnYPknMO106BWg-FRWN2Arks5rdZ4DgaJpZM4MD5P7.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany-plugins/pull/527#pullrequestreview-22491553"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany-plugins","title":"geany/geany-plugins","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany-plugins"}},"updates":{"snippets":[{"icon":"PERSON","message":"@b4n approved #527"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany-plugins/pull/527#pullrequestreview-22491553"}}}</script>