<p><b>@b4n</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/1382#pullrequestreview-18989364">data/geany.gtkrc</a>:</p>
<pre style='color:#555'>> @@ -56,8 +56,8 @@ style "geany-compiler-error-style" {
     fg[ACTIVE] = "#ffff00000000"
 }
 style "geany-compiler-context-style" {
-    fg[NORMAL] = "#888800000000"
-    fg[ACTIVE] = "#888800000000"
+    fg[NORMAL] = "#7f7f00000000"
+    fg[ACTIVE] = "#7f7f00000000"
</pre>
<p>Odd choice?  AFAIK these are 3 16bits values, not 6 8bits ones.  (BTW, AFAIK it's also possible to use the short 8bit values instead of the 16bits ones)</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/1382#pullrequestreview-18989364">doc/geany.txt</a>:</p>
<pre style='color:#555'>> @@ -494,6 +494,27 @@ An example of a simple ``.gtkrc-2.0``::
     widget "GeanyPrefsDialog" style "geanyStyle"
 
 
+Customizing Geany's appearance using GTK+ 3 CSS
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+
+To override GTK+ CSS styles, you can use traditional mechanisms or you
+can create a file named ``geany.css`` in the user configuration directory
+(usually ``~/.config/geany``) which will be loaded after other CSS styles
</pre>
<p>might be interesting linking <a href="http://www.geany.org/manual/#configuration-file-paths">http://www.geany.org/manual/#configuration-file-paths</a></p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/1382#pullrequestreview-18989364">src/msgwindow.c</a>:</p>
<pre style='color:#555'>> @@ -112,6 +117,40 @@ void msgwin_set_messages_dir(const gchar *messages_dir)
 }
 
 
+GdkColor load_color(gchar *color_name) {
</pre>
<p>could this avoid returning an aggregate and "return" through an arg?  Yeah I know it's valid C and all, but it's copying at least twice the data (well, 12 instead of 8 bytes on a Linux 64), and it's common to return "by reference" (don't lynch me :]) in such cases.<br>
I don't mind <em>so</em> much, but I build with <code>-Waggregate-return</code> -- and yeah, it <em>did</em> spot some meaningful issue once or twice (ok, in other ppl's code generally, but still)</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/1382#pullrequestreview-18989364">src/ui_utils.c</a>:</p>
<pre style='color:#555'>> +    theme_fn = g_build_filename(app->datadir, "geany.css", NULL);
+       load_css_theme(theme_fn, GTK_STYLE_PROVIDER_PRIORITY_APPLICATION);
+       g_free(theme_fn);
+
+       // load themes to handle breakage between various GTK+ versions
+       const struct
+       {
+               guint min_version;
+               guint max_version;
+               const gchar *file;
+       }
+       css_files[] =
+       {
+               { 20, G_MAXUINT, "geany-3.20.css" },
+               { 0, 19, "geany-3.0.css" },
+       };
</pre>
<p>Any reason why you still change how it's loaded?  I don't really mind both seem OK, but AFAIK there's no more point in changing it, and I fairly like the in-CSS flexibility of the <code>@import</code>.  No biggie though.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1382#pullrequestreview-18989364">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ0FhGLBlggNGubmb939B-tIiFXZMks5rXJa6gaJpZM4Lwb0d">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ3hPKw6KOz1ESJ6whxFpw8PDzscUks5rXJa6gaJpZM4Lwb0d.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1382#pullrequestreview-18989364"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@b4n commented on #1382"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1382#pullrequestreview-18989364"}}}</script>