<blockquote>
<p>More generally I still don't really like/understand why we need the $configdir/geany.css stuff, as the only use case for it seems to style GTK stock dialogs differently inside Geany only (which seems an artificial need, but well)</p>
</blockquote>
<p>That's just an example use-case (even if the only one), but the idea is that instead of us dictating what the user can style, they can just use normal CSS without being limited by stuff we happen to have given IDs too (or stuff below it). Also, the CSS doesn't require to make every selector contain <code>GeanyWhatever</code> or <code>geany-whatever</code>.</p>
<p>Finally, it's a completely trivial <a href="https://github.com/geany/geany/pull/1382/files#diff-4bbd8d1b91370dfb89a7e350b9828785R2532">4-lines of code</a> to make it work and it doesn't prevent the user from using other mechanism/file (ex. <code>~/.config/gtk-3.0/gtk.css</code>) to style Geany.</p>
<blockquote>
<p>IMO it makes more sense to let user use the GTK-provided facility for that</p>
</blockquote>
<p>Why can't they if they want to?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1382#issuecomment-275932134">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ5KbnHOdnps7U6RukIOltuKK0zuxks5rXNIhgaJpZM4Lwb0d">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJySfJ_E0OutQTFXdWpiyRzeaoKHJks5rXNIhgaJpZM4Lwb0d.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1382#issuecomment-275932134"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@codebrainz in #1382: \u003e More generally I still don't really like/understand why we need the $configdir/geany.css stuff, as the only use case for it seems to style GTK stock dialogs differently inside Geany only (which seems an artificial need, but well)\r\n\r\nThat's just an example use-case (even if the only one), but the idea is that instead of us dictating what the user can style, they can just use normal CSS without being limited by stuff we happen to have given IDs too (or stuff below it). Also, the CSS doesn't require to make every selector contain `GeanyWhatever` or `geany-whatever`.\r\n\r\nFinally, it's a completely trivial [4-lines of code](https://github.com/geany/geany/pull/1382/files#diff-4bbd8d1b91370dfb89a7e350b9828785R2532) to make it work and it doesn't prevent the user from using other mechanism/file (ex. `~/.config/gtk-3.0/gtk.css`) to style Geany.\r\n\r\n\u003e IMO it makes more sense to let user use the GTK-provided facility for that\r\n\r\nWhy can't they if they want to?"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1382#issuecomment-275932134"}}}</script>