<p><b>@b4n</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/geany/geany/pull/1382#pullrequestreview-18975170">data/geany-3.0.css</a>:</p>
<pre style='color:#555'>> @@ -1,10 +0,0 @@
-@import "geany.css";
-
-/* make close button on the editor's tabs smaller */
-#geany-close-tab-button {
- -GtkWidget-focus-padding: 0;
- -GtkWidget-focus-line-width: 0;
- -GtkButton-default-border: 0;
- -GtkButton-default-outside-border: 0;
- -GtkButton-inner-border: 0;
-}
</pre>
<p>IIUC this was conditional and not loaded on 3.20 because it was redundant, and would possibly lead to runtime deprecation warnings. Why drop it?</p>
<hr>
<p>In <a href="https://github.com/geany/geany/pull/1382#pullrequestreview-18975170">src/ui_utils.c</a>:</p>
<pre style='color:#555'>> }
- g_object_unref(css);
- g_free(css_file);
-#else
- /* see setup_gtk2_styles() in main.c */
+ // if the user provided a geany.css file in their config dir, try and load that
</pre>
<p>Do we really need that? Isn't <em>~/.config/gtk-3.0/gtk.css</em> enough? AFAIK all our styles can easily be applied to Geany only, so I don't see why we'd need extra stuff?</p>
<hr>
<p>In <a href="https://github.com/geany/geany/pull/1382#pullrequestreview-18975170">doc/geany.txt</a>:</p>
<pre style='color:#555'>> @@ -494,6 +494,27 @@ An example of a simple ``.gtkrc-2.0``::
widget "GeanyPrefsDialog" style "geanyStyle"
+Customizing Geany's appearance using GTK+ 3 CSS
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+
+To override GTK+ CSS styles, you can use traditional mechanisms or you
+can create a file named ``geany.css`` in the user configuration directory
+(usually ``~/.config/geany``) which will be loaded after other CSS styles
+are applied to allow overriding the default styles.
+
+Geany offers a number of CSS classes which can be overridden to taylor its
</pre>
<p>Those are CSS IDs (<code>#name</code>), not classes (<code>.name</code>)</p>
<hr>
<p>In <a href="https://github.com/geany/geany/pull/1382#pullrequestreview-18975170">src/msgwindow.c</a>:</p>
<pre style='color:#555'>> @@ -83,6 +83,11 @@ enum
};
+static GdkColor color_error = {0, 65535, 0, 0};
+static GdkColor color_context = {0, 65535 / 2, 0, 0};
+static GdkColor color_message = {0, 0, 0, 0xD000};
</pre>
<p>different literals look odd, I'd rather use <code>0xFFFF</code> and <code>0x7FFF</code></p>
<hr>
<p>In <a href="https://github.com/geany/geany/pull/1382#pullrequestreview-18975170">src/ui_utils.c</a>:</p>
<pre style='color:#555'>> @@ -2097,7 +2097,9 @@ static void on_config_file_clicked(GtkWidget *widget, gpointer user_data)
if (g_file_test(global_file, G_FILE_TEST_EXISTS))
g_file_get_contents(global_file, &global_content, NULL, NULL);
- document_new_file(utf8_filename, ft, global_content);
+ // open or create the document and mark it as changed if it didn't already exist
+ GeanyDocument *doc = document_new_file(utf8_filename, ft, global_content);
+ document_set_text_changed(doc, ! g_file_test(file_name, G_FILE_TEST_EXISTS));
</pre>
<p>Why? saving an empty file, or a copy of the system version, doesn't seem to useful?</p>
<hr>
<p>In <a href="https://github.com/geany/geany/pull/1382#pullrequestreview-18975170">data/geany.css</a>:</p>
<pre style='color:#555'>> @@ -36,6 +36,17 @@
color: #007f00;
}
+/* compiler message colors */
+#geany-compiler-error {
+ color: #ff0000;
+}
+#geany-compiler-context {
+ color: #880000;
</pre>
<p>shouldn't that be <code>0x7f0000</code> to be the same as the hardcoded one? Not that it matters too much though, I don't imagine anybody will really see the difference</p>
<hr>
<p>In <a href="https://github.com/geany/geany/pull/1382#pullrequestreview-18975170">data/geany.gtkrc</a>:</p>
<pre style='color:#555'>> @@ -50,5 +50,22 @@ widget "*.geany-document-status-changed" style "geany-document-status-changed-st
widget "*.geany-document-status-disk-changed" style "geany-document-status-disk-changed-style"
widget "*.geany-document-status-readonly" style "geany-document-status-readonly-style"
+# compiler message colors
+style "geany-compiler-error-style" {
+ fg[NORMAL] = "#ffff00000000"
+ fg[ACTIVE] = "#ffff00000000"
+}
+style "geany-compiler-context-style" {
+ fg[NORMAL] = "#888800000000"
+ fg[ACTIVE] = "#888800000000"
</pre>
<p>same pickyness than for the GTK3 variant, for me <code>65535 / 2</code> is <code>7fff</code></p>
<hr>
<p>In <a href="https://github.com/geany/geany/pull/1382#pullrequestreview-18975170">src/msgwindow.c</a>:</p>
<pre style='color:#555'>> switch (msg_color)
{
case COLOR_RED: return &color_error;
- case COLOR_DARK_RED: return &dark_red;
- case COLOR_BLUE: return &blue;
+ case COLOR_DARK_RED: return &color_context;
+ case COLOR_BLUE: return &color_message;
</pre>
<p>We really should rename those color names someday to something semantic. But well.</p>
<hr>
<p>In <a href="https://github.com/geany/geany/pull/1382#pullrequestreview-18975170">src/msgwindow.c</a>:</p>
<pre style='color:#555'>> @@ -83,6 +83,11 @@ enum
};
+static GdkColor color_error = {0, 65535, 0, 0};
+static GdkColor color_context = {0, 65535 / 2, 0, 0};
+static GdkColor color_message = {0, 0, 0, 0xD000};
</pre>
<p>OK I see it comes from the old code. Well, as you want then, but could be the occasion to make that less odd :)</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1382#pullrequestreview-18975170">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ36yGKeEGpZiRq-FEnlQhhs25p_Iks5rW2O6gaJpZM4Lwb0d">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ1yi6Yt-AjvdvfJTbfDds1sgGI3lks5rW2O6gaJpZM4Lwb0d.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/geany/geany/pull/1382#pullrequestreview-18975170"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@b4n commented on #1382"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1382#pullrequestreview-18975170"}}}</script>