<p>+1 for unhardcoding these colours, but I think it would be better to use GTK+ theming for this. The colour schemes are only supposed to affect the Scintilla editor widget. In other places where we affect the other widgets (ex. tab label colour, search entry background, etc) we already use GTK+ themes. It may even be possible to re-use the colours from GTK+ itself, like using the warning, error, info, and other colours used by GtkInfoBar, so that native dark or light GTK+ themes "just work" out of the box without having to futz with a whole other colour scheme system.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1377#issuecomment-275135349">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ0VL_DHS62TD1XB6WjlSReJtLDrJks5rV2fPgaJpZM4LtI7n">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJzRWTcKoWa6IfYWuMDBxPP7zcSiJks5rV2fPgaJpZM4LtI7n.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1377#issuecomment-275135349"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@codebrainz in #1377: +1 for unhardcoding these colours, but I think it would be better to use GTK+ theming for this. The colour schemes are only supposed to affect the Scintilla editor widget. In other places where we affect the other widgets (ex. tab label colour, search entry background, etc) we already use GTK+ themes. It may even be possible to re-use the colours from GTK+ itself, like using the warning, error, info, and other colours used by GtkInfoBar, so that native dark or light GTK+ themes \"just work\" out of the box without having to futz with a whole other colour scheme system."}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1377#issuecomment-275135349"}}}</script>